-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically adding the "missing" amplitudes from Psi4. #41
Comments
I would assume this problem persists with ROHF right? If so then yes we should extract the amplitudes for the users! |
The problem is solved when using ROHF (which in OpenFermion-Psi4 is used when multiplicity is not equal to 1). |
Hey @bsenjean, sorry getting back to this. I too ran into something similar where I learned the CCSD closed shell amplitudes are S2 and Sz spin adapted (from a very old paper in the 80's which everyone cites). Therefore, as psi4 forum mentions same-spin t2 are defined as T_IJAB = T_IjAb - T_IjBa = T_ijab. Is that what you mean? |
Yes, typically these amplitudes are required and computed inside Psi4 but they do not print them as they can be determined from the others by the expression T_IJAB = T_IjAb - T_IjBa = T_ijab. So one should also extract them in OpenFermion otherwise you'll see that you don't get the correct CCSD energy. One of our student made a subroutine to add them to the ccsd operator in OpenFermion, see below (it could certainly be more compacted):
|
Great. Do you or the student want to submit this as a PR? It would be nice to have so others know how to "unspin-adapt" the amplitudes. |
Sure, I guess a good place would be I could either modify directly |
Alright, I added the pull request. I tried to minimize the coding as much as possible, i.e. by only adding one dictionary to store the amplitudes that I needed to compute the same-spin amplitudes for restricted/closed-shell calculations. I checked the CCSD energy resulting from these new amplitudes for H4 and LiH, and it worked well (I recover the correct energy up to single precision). |
Hi,
When I tried to recover the CCSD energy based on the CCSD amplitudes extracted from OpenFermion-Psi4, I realized that some were missing: the same-spin amplitudes.
See here for a question I asked on the Psi4 forum: http://forum.psicode.org/t/understanding-mp2-ccsd-amplitudes-for-h4/1866
Also this is not an issue as they can be determined later on, I think it would actually be better to extract those directly from the OpenFermion-Psi4 interface, because I'm pretty sure most user will not know that they are missing. And CCSD amplitudes could be used in some UCC ansatz.
The text was updated successfully, but these errors were encountered: