Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently does not build #112

Closed
incebellipipo opened this issue Feb 14, 2025 · 3 comments
Closed

Currently does not build #112

incebellipipo opened this issue Feb 14, 2025 · 3 comments

Comments

@incebellipipo
Copy link

Please see PR #110.

$ cmake --build build
[  4%] Building CXX object CMakeFiles/qualisys_cpp_sdk.dir/Markup.cpp.o
[  9%] Building CXX object CMakeFiles/qualisys_cpp_sdk.dir/Network.cpp.o
[ 14%] Building CXX object CMakeFiles/qualisys_cpp_sdk.dir/RTPacket.cpp.o
[ 19%] Building CXX object CMakeFiles/qualisys_cpp_sdk.dir/RTProtocol.cpp.o
qualisys_cpp_sdk/RTProtocol.cpp: In member function ‘bool CRTProtocol::GetCapture(const char*, bool)’:
qualisys_cpp_sdk/RTProtocol.cpp:685:66: warning: ‘%s’ directive writing up to 1023 bytes into a region of size 1004 [-Wformat-overflow=]
  685 |                         sprintf(maErrorStr, "No packet received. %s.", maErrorStr);
      |                                                                  ^~
qualisys_cpp_sdk/RTProtocol.cpp:685:32: note: ‘sprintf’ output between 22 and 1045 bytes into a destination of size 1024
  685 |                         sprintf(maErrorStr, "No packet received. %s.", maErrorStr);
      |                         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 23%] Building CXX object CMakeFiles/qualisys_cpp_sdk.dir/Settings.cpp.o
qualisys_cpp_sdk/Settings.cpp: In function ‘const char* qualisys_cpp_sdk::SkeletonDofToStringSettings(qualisys_cpp_sdk::EDegreeOfFreedom)’:
qualisys_cpp_sdk/Settings.cpp:5:20: error: ‘find_if’ is not a member of ‘std’
    5 |     auto it = std::find_if(DEGREES_OF_FREEDOM.begin(), DEGREES_OF_FREEDOM.end(), [&](const auto& DEGREE_OF_FREEDOM) { return (DEGREE_OF_FREEDOM.first == dof); });
      |                    ^~~~~~~
qualisys_cpp_sdk/Settings.cpp: In function ‘qualisys_cpp_sdk::EDegreeOfFreedom qualisys_cpp_sdk::SkeletonStringToDofSettings(const string&)’:
qualisys_cpp_sdk/Settings.cpp:17:20: error: ‘find_if’ is not a member of ‘std’
   17 |     auto it = std::find_if(DEGREES_OF_FREEDOM.begin(), DEGREES_OF_FREEDOM.end(), [&](const auto& DEGREE_OF_FREEDOM) { return (DEGREE_OF_FREEDOM.second == str); });
      |                    ^~~~~~~
gmake[2]: *** [CMakeFiles/qualisys_cpp_sdk.dir/build.make:135: CMakeFiles/qualisys_cpp_sdk.dir/Settings.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:182: CMakeFiles/qualisys_cpp_sdk.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
@bahlborn
Copy link

Hello. We are in the middle of some refactoring. We expect to finish next week, and If this is still an issue we will address it at that time. Sorry for leaking some mess.

@incebellipipo
Copy link
Author

No worries.

In our build chain, we pull the latest qualisys_cpp_sdk using FetchContent CMake directive. Automated builds have been failing recently. I wasn't expecting master branch to have this issue 😅. But, I will change it to a working commit hash or a version tag once the refactoring is done.

Here is how I pull it: https://github.com/incebellipipo/mocap4ros2_qualisys/blob/21e6863fa6d8e44c6c8f24e2484d33c9d8c01244/qualisys_driver/CMakeLists.txt#L25-L36

@qjgn
Copy link
Contributor

qjgn commented Feb 17, 2025

This issue has been fixed as of #109
Unfortunately we don't have automatic testing for mac/linux right now, however the releases should be more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants