Replaced the custom "xsplit" function with the standard JavaScript split function #32
Labels
Comments
herrvigg
added
enhancement
|
I tested the change in a lot of browsers. The only ones that failed were IE <= 8 (where WordPress displays a big warning message in the admin area so) and Konqueror (even in the most recent version). All other browsers I tested work fine. You can test for yourself if the "split" function is implemented correctly in a certain browser with this simple test page: http://michel.weimerskirch.net/xsplit-test.html (e.g. using browserstack.com). IMHO this patch can be applied. |
herrvigg
added
legacy PR
|
The problem is not Eventually we may break the support for IE11 that only receives minimum security updates but that should be consistent with |
herrvigg
added a commit
that referenced
this issue
Apr 7, 2023
WordPress abandonned support of IE with WP5.8 in July 2021. Though we don't require that version of WP, it's time to abandon that legacy. See also this very old ticket: #32. 1) Remove workaround for RegExp:@@split See also https://caniuse.com/?search=%40%40split 2) Update our `browserlist` for JS to be synced with WordPress https://github.com/WordPress/wordpress-develop/blob/trunk/package.json 3) Add more debug info about browser in the troubleshooting section.
herrvigg
added a commit
that referenced
this issue
Apr 7, 2023
WordPress abandonned support of IE with WP5.8 in July 2021. https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/ Though we don't require that version of WP, it's time to abandon that legacy. See also this very old ticket: #32. 1) Remove workaround for RegExp:@@split See also https://caniuse.com/?search=%40%40split 2) Update our `browserlist` for JS to be synced with WordPress https://github.com/WordPress/wordpress-develop/blob/trunk/package.json 3) Add more debug info about browser in the troubleshooting section.
herrvigg
added a commit
that referenced
this issue
Apr 7, 2023
WordPress abandonned support of IE with WP5.8 in July 2021. https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/ Though we don't require that version of WP, it's time to abandon that legacy. See also this very old ticket: #32. 1) Remove workaround for `RegExp:@@split` See also https://caniuse.com/?search=%40%40split 2) Update our `browserlist` for JS to be synced with WordPress https://github.com/WordPress/wordpress-develop/blob/trunk/package.json 3) Add more debug info about browser in the troubleshooting section.
herrvigg
added a commit
that referenced
this issue
Apr 7, 2023
WordPress abandonned support of IE with WP5.8 in July 2021. https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/ Though we don't require that version of WP, it's time to abandon that legacy. See also this very old ticket: #32. 1) Remove workaround for `RegExp:@@split` See also https://caniuse.com/?search=%40%40split 2) Update our `browserslist` for JS to be synced with WordPress https://github.com/WordPress/wordpress-develop/blob/trunk/package.json 3) Add more debug info about browser in the troubleshooting section.
herrvigg
added a commit
that referenced
this issue
Apr 7, 2023
WordPress abandoned support of IE with WP5.8 in July 2021. https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/ Though we don't require that version of WP, it's time to abandon that legacy. See also this very old ticket: #32. 1) Remove workaround for `RegExp:@@split` See also https://caniuse.com/?search=%40%40split 2) Update our `browserslist` for JS to be synced with WordPress https://github.com/WordPress/wordpress-develop/blob/trunk/package.json 3) Add more debug info about browser in the troubleshooting section.
herrvigg
added a commit
that referenced
this issue
Apr 7, 2023
WordPress abandoned support of IE with WP5.8 in July 2021. https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/ Though we don't require that version of WP, it's time to abandon that legacy. See also this very old ticket: #32. 1) Remove workaround for `RegExp:@@split` See also https://caniuse.com/mdn-javascript_builtins_regexp_--split 2) Update our `browserslist` for JS to be synced with WordPress https://github.com/WordPress/wordpress-develop/blob/trunk/package.json 3) Add more debug info about browser in the troubleshooting section.
herrvigg
added a commit
that referenced
this issue
Apr 7, 2023
WordPress abandoned the support of IE with WP5.8 in July 2021. https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/ Though we don't require that version of WP, it's time to abandon that legacy. See also this very old ticket: #32. 1) Remove workaround for `RegExp:@@split` See also https://caniuse.com/mdn-javascript_builtins_regexp_--split 2) Update our `browserslist` for JS to be synced with WordPress https://github.com/WordPress/wordpress-develop/blob/trunk/package.json 3) Add more debug info about browser in the troubleshooting section.
herrvigg
added a commit
that referenced
this issue
Apr 7, 2023
WordPress abandoned the support of IE with WP5.8 in July 2021. https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/ Though we don't require that version of WP, it's time to abandon that legacy. See also this very old ticket: #32. 1) Remove workaround for `RegExp:@@split` See also https://caniuse.com/mdn-javascript_builtins_regexp_--split 2) Update our `browserslist` for JS to be synced with WordPress https://github.com/WordPress/wordpress-develop/blob/trunk/package.json 3) Add more debug info about browser in the troubleshooting section.
|
Fixed by #1313. |
herrvigg
added a commit
that referenced
this issue
Apr 7, 2023
WordPress abandoned the support of IE with WP5.8 in July 2021. https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/ Though we don't require that version of WP, it's time to abandon that legacy. See also this very old ticket: #32. 1) Remove workaround for `RegExp:@@split` See also https://caniuse.com/mdn-javascript_builtins_regexp_--split 2) Add more debug info about browser in the troubleshooting section.
herrvigg
added a commit
that referenced
this issue
Apr 7, 2023
WordPress abandoned the support of IE with WP5.8 in July 2021. https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/ Though we don't require that version of WP, it's time to abandon that legacy. See also this very old ticket: #32. 1) Remove workaround for `RegExp:@@split` See also https://caniuse.com/mdn-javascript_builtins_regexp_--split 2) Add more debug info about browser in the troubleshooting section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Monday Feb 23, 2015 at 23:14 GMT
Originally opened as qTranslate-Team/qtranslate-x#32
I'm still trying to make the code more readable and easier to test and extend. IMHO the "xsplit" function can be removed. The function was necessary for qtranslate to be compatible with older browsers. Newer browser that implement ECMAScript 5 (this includes IE 9 in "standards mode") do not need this any longer. This would make the code a bit more readable, but IE 8 on the other hand would no longer be compatible. However, as WordPress displays a big warning when you use the admin area with IE 8 (or other old browsers), this should not be a problem.
mweimerskirch included the following code: https://github.com/qTranslate-Team/qtranslate-x/pull/32/commits
The text was updated successfully, but these errors were encountered: