Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/collection/new endpoint stages an initial commit #602

Open
b5 opened this issue Sep 28, 2020 · 0 comments
Open

/collection/new endpoint stages an initial commit #602

b5 opened this issue Sep 28, 2020 · 0 comments
Labels
workbench workbench section

Comments

@b5
Copy link
Member

b5 commented Sep 28, 2020

This builds on #601, where we're adding in a new way to build initial datasets. For this section let's focus on a route within the collection section at /collection/new that stages a dataset document for initial commit creation. This "new" view should work the exact same as the "status" workbench editor with some exceptions:

  • /collection/new should not try to fetch history
  • user should be able to edit meta & add a readme in this early state
  • It should but have additional validation logic that confirms the dataset will be accepted by the backend:
    • Users must add a body before they can commit, and should have feedback that shows a body is needed
  • having a staged body should notify the user that a structure will be inferred for now, and not let them edit structure
  • dataset name should be editable from this screen

All of this should be possible as a new route that uses existing components, so this PR should mainly be realized as changes to workbench components & an added route to the collection table.

This PR should not worry about the actual actions that submit & create the initial dataset, instead just work on programmatically navigating to /collection/new. A valid commit should just log the dataset document to the console in the click handler/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workbench workbench section
Projects
None yet
Development

No branches or pull requests

1 participant