Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Commit 6a38a4a

Browse files
committed
Upgrade packages
- @angular/cli ^1.2.0 - @angular to ^4.0.0
1 parent 4feee6c commit 6a38a4a

12 files changed

+75
-51
lines changed

.angular-cli.json

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@
1515
"index": "index.html",
1616
"main": "main.ts",
1717
"polyfills": "polyfills.ts",
18-
"test": "test.ts",
18+
"test": "../../src/test.ts",
1919
"tsconfig": "tsconfig.json",
20+
"testTsconfig": "../../src/tsconfig.spec.json",
2021
"prefix": "app",
2122
"styles": [
2223
"../../node_modules/bootstrap/dist/css/bootstrap.css",
@@ -31,14 +32,20 @@
3132
}
3233
}
3334
],
35+
"e2e": {
36+
"protractor": {
37+
"config": "./protractor.conf.js"
38+
}
39+
},
3440
"lint": [
3541
{
36-
"files": "src/**/*.ts",
37-
"project": "src/tsconfig.json"
42+
"project": "src/tsconfig.app.json"
43+
},
44+
{
45+
"project": "src/tsconfig.spec.json"
3846
},
3947
{
40-
"files": "e2e/**/*.ts",
41-
"project": "e2e/tsconfig.json"
48+
"project": "e2e/tsconfig.e2e.json"
4249
}
4350
],
4451
"test": {

demo/src/main.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {enableProdMode} from '@angular/core';
22
import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
33

44
import {AppModule} from './app/app.module';
5-
import {environment} from './environments/environment';
5+
import {environment} from '../../environments/environment';
66

77
if (environment.production) {
88
enableProdMode();

demo/src/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"compileOnSave": false,
23
"compilerOptions": {
34
"baseUrl": "",
45
"declaration": false,
File renamed without changes.

karma.conf.js

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,29 +12,17 @@ module.exports = function (config) {
1212
require('karma-coverage-istanbul-reporter'),
1313
require('@angular/cli/plugins/karma')
1414
],
15-
client:{
15+
client: {
1616
clearContext: false // leave Jasmine Spec Runner output visible in browser
1717
},
18-
files: [
19-
{ pattern: './src/test.ts', watched: false }
20-
],
21-
preprocessors: {
22-
'./src/test.ts': ['@angular/cli']
23-
},
24-
mime: {
25-
'text/x-typescript': ['ts','tsx']
26-
},
2718
coverageIstanbulReporter: {
28-
reports: [ 'html', 'lcovonly' ],
19+
reports: ['html', 'lcovonly'],
2920
fixWebpackSourcePaths: true
3021
},
3122
angularCli: {
32-
config: './.angular-cli.json',
3323
environment: 'dev'
3424
},
35-
reporters: config.angularCli && config.angularCli.codeCoverage
36-
? ['progress', 'coverage-istanbul']
37-
: ['progress', 'kjhtml'],
25+
reporters: ['progress', 'kjhtml'],
3826
port: 9876,
3927
colors: true,
4028
logLevel: config.LOG_INFO,

package.json

Lines changed: 30 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
"angular-cli": {},
66
"scripts": {
77
"start": "ng serve",
8+
"build": "ng build",
9+
"lint": "ng lint",
10+
"e2e": "ng e2e",
811
"test": "./node_modules/.bin/karma --config karma.conf.js start",
912
"gh-pages" : "ng build --env=prod --base-href \"https://qjon.github.io/angular2-tree/\" && ./node_modules/.bin/angular-cli-ghpages -b gh-pages --name=\"Rafał Ignaszewski\" --email=\"[email protected]\" --no-silent"
1013
},
@@ -15,45 +18,48 @@
1518
"main": "main",
1619
"author": "Rafal Ignaszewski <[email protected]> http://ignaszewski.pl",
1720
"dependencies": {
18-
"@angular/common": "^2.4.0",
19-
"@angular/compiler": "^2.4.0",
20-
"@angular/core": "^2.4.0",
21-
"@angular/forms": "^2.4.0",
22-
"@angular/http": "^2.4.0",
23-
"@angular/platform-browser": "^2.4.0",
24-
"@angular/platform-browser-dynamic": "^2.4.0",
25-
"@angular/router": "^3.4.0",
21+
"@angular/animations": "^4.0.0",
22+
"@angular/common": "^4.0.0",
23+
"@angular/compiler": "^4.0.0",
24+
"@angular/core": "^4.0.0",
25+
"@angular/forms": "^4.0.0",
26+
"@angular/http": "^4.0.0",
27+
"@angular/platform-browser": "^4.0.0",
28+
"@angular/platform-browser-dynamic": "^4.0.0",
29+
"@angular/router": "^4.0.0",
30+
"zone.js": "^0.8.4",
2631
"@ngrx/core": "^1.2.0",
2732
"@ngrx/effects": "^2.0.3",
33+
"core-js": "^2.4.1",
2834
"@ngrx/store": "^2.2.2",
2935
"angular2-contextmenu": "^0.7.7",
3036
"angular2-uuid": "^1.1.1",
3137
"bootstrap": "^3.3.7",
32-
"core-js": "^2.4.1",
3338
"font-awesome": "^4.6.3",
3439
"ng2-dnd": "^2.2.2",
35-
"rxjs": "^5.1.0",
36-
"zone.js": "^0.7.6"
40+
"rxjs": "^5.1.0"
3741
},
3842
"devDependencies": {
39-
"@angular/cli": "1.0.0-beta.32.3",
40-
"@angular/compiler-cli": "^2.4.0",
43+
"@angular/cli": "1.2.0",
44+
"@angular/compiler-cli": "^4.0.0",
45+
"@angular/language-service": "^4.0.0",
4146
"@ngrx/store-devtools": "^3.2.4",
42-
"@types/jasmine": "2.5.38",
47+
"@types/jasmine": "~2.5.53",
48+
"@types/jasminewd2": "~2.0.2",
4349
"@types/node": "~6.0.60",
4450
"angular-cli-ghpages": "^0.5.1",
45-
"codelyzer": "~2.0.0-beta.4",
46-
"jasmine-core": "~2.5.2",
47-
"jasmine-spec-reporter": "~3.2.0",
48-
"karma": "~1.4.1",
49-
"karma-chrome-launcher": "~2.0.0",
51+
"codelyzer": "~3.0.1",
52+
"jasmine-core": "~2.6.2",
53+
"jasmine-spec-reporter": "~4.1.0",
54+
"karma": "~1.7.0",
55+
"karma-chrome-launcher": "~2.1.1",
5056
"karma-cli": "~1.0.1",
51-
"karma-coverage-istanbul-reporter": "^0.2.0",
57+
"karma-coverage-istanbul-reporter": "^1.2.1",
5258
"karma-jasmine": "~1.1.0",
5359
"karma-jasmine-html-reporter": "^0.2.2",
54-
"protractor": "~5.1.0",
55-
"ts-node": "~2.0.0",
56-
"tslint": "~4.4.2",
57-
"typescript": "~2.0.0"
60+
"protractor": "~5.1.2",
61+
"ts-node": "~3.0.4",
62+
"tslint": "~5.3.2",
63+
"typescript": "~2.3.3"
5864
}
5965
}

src/models/TreeModel.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ describe('TreeModel', () => {
3535

3636
describe('getRootNodes', () => {
3737
it('should return what getChildren return', () => {
38-
const expectedValue = [];
38+
const expectedValue = Observable.of([]);
3939

4040
spyOn(treeModel, 'getChildren').and.returnValue(expectedValue)
4141

src/models/TreeModel.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {IOuterNode} from '../interfaces/IOuterNode';
22
import {Observable} from 'rxjs/Observable';
33
import {IConfiguration} from '../interfaces/IConfiguration';
4-
import {ITreeData, ITreeState} from '../store/ITreeState';
4+
import {ITreeData} from '../store/ITreeState';
55
import {BehaviorSubject} from 'rxjs/BehaviorSubject';
66

77
export class TreeModel {
@@ -22,7 +22,7 @@ export class TreeModel {
2222

2323
public getChildren(nodeId: string | null) {
2424
return this.nodes$
25-
.map((state: ITreeData) => this.getNodesByParentId(state, nodeId))
25+
.map((state: ITreeData): IOuterNode[] => this.getNodesByParentId(state, nodeId))
2626
.map((nodes: IOuterNode[]) => {
2727
return nodes.sort(this.sortNodes);
2828
});

src/store/treeReducer.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ function insertNode(state: ITreeState, action: Action): ITreeState {
8282
parents: []
8383
};
8484

85-
newState[action.payload.treeId][null] = newNode;
85+
newState[action.payload.treeId][0] = newNode;
8686

8787
return newState;
8888
}
@@ -94,8 +94,8 @@ function saveNode(state: ITreeState, action: ITreeAction): ITreeState {
9494
const treeId = action.payload.treeId;
9595
const treeState = newState[treeId];
9696

97-
if (treeState[null]) {
98-
delete treeState[null];
97+
if (treeState[0]) {
98+
delete treeState[0];
9999
} else {
100100
delete treeState[old.id];
101101
}

src/test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ import {
1212
platformBrowserDynamicTesting
1313
} from '@angular/platform-browser-dynamic/testing';
1414

15+
import 'rxjs/Rx';
16+
1517
// Unfortunately there's no typing for the `__karma__` variable. Just declare it as any.
1618
declare const __karma__: any;
1719
declare const require: any;

src/tsconfig.spec.json

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
{
2+
"extends": "../demo/src/tsconfig.json",
3+
"compilerOptions": {
4+
"outDir": "../out-tsc/spec",
5+
"module": "commonjs",
6+
"target": "es5",
7+
"baseUrl": "",
8+
"types": [
9+
"jasmine",
10+
"node"
11+
]
12+
},
13+
"files": [
14+
"test.ts"
15+
],
16+
"include": [
17+
"**/*.spec.ts",
18+
"**/*.d.ts"
19+
]
20+
}

0 commit comments

Comments
 (0)