From 8bd34d1881b79570191db957429f03d74f3cd602 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C6=A1n=20Phan=20Trung?=
 <94152483+sonphantrung@users.noreply.github.com>
Date: Tue, 26 Dec 2023 20:11:16 +0700
Subject: [PATCH] chore: get run.sh to be POSIX Compliant (#1649)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Create CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* fix: get run.sh posix compliant

* Update venv.sh

* Delete CONTRIBUTING.md

---------

Co-authored-by: 源文雨 <41315874+fumiama@users.noreply.github.com>
---
 run.sh  | 20 ++++++++++----------
 venv.sh |  2 ++
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/run.sh b/run.sh
index 704c9fff2..d3f720e2a 100755
--- a/run.sh
+++ b/run.sh
@@ -1,27 +1,27 @@
-#!/bin/bash
+#!/bin/sh
 
-if [[ "$(uname)" == "Darwin" ]]; then
+if [ "$(uname)" = "Darwin" ]; then
   # macOS specific env:
   export PYTORCH_ENABLE_MPS_FALLBACK=1
   export PYTORCH_MPS_HIGH_WATERMARK_RATIO=0.0
-elif [[ "$(uname)" != "Linux" ]]; then
+elif [ "$(uname)" != "Linux" ]; then
   echo "Unsupported operating system."
   exit 1
 fi
 
 if [ -d ".venv" ]; then
   echo "Activate venv..."
-  source .venv/bin/activate
+  . .venv/bin/activate
 else
   echo "Create venv..."
   requirements_file="requirements.txt"
 
   # Check if Python 3.8 is installed
-  if ! command -v python3 &> /dev/null; then
+  if ! command -v python3 >/dev/null 2>&1; then
     echo "Python 3 not found. Attempting to install 3.8..."
-    if [[ "$(uname)" == "Darwin" ]] && command -v brew &> /dev/null; then
+    if [ "$(uname)" = "Darwin" ] && command -v brew >/dev/null 2>&1; then
       brew install python@3.8
-    elif [[ "$(uname)" == "Linux" ]] && command -v apt-get &> /dev/null; then
+    elif [ "$(uname)" = "Linux" ] && command -v apt-get >/dev/null 2>&1; then
       sudo apt-get update
       sudo apt-get install python3.8
     else
@@ -31,13 +31,13 @@ else
   fi
 
   python3 -m venv .venv
-  source .venv/bin/activate
+  . .venv/bin/activate
 
   # Check if required packages are installed and install them if not
   if [ -f "${requirements_file}" ]; then
     installed_packages=$(python3 -m pip freeze)
     while IFS= read -r package; do
-      [[ "${package}" =~ ^#.* ]] && continue
+      expr "${package}" : "^#.*" > /dev/null && continue
       package_name=$(echo "${package}" | sed 's/[<>=!].*//')
       if ! echo "${installed_packages}" | grep -q "${package_name}"; then
         echo "${package_name} not found. Attempting to install..."
@@ -53,7 +53,7 @@ fi
 # Download models
 ./tools/dlmodels.sh
 
-if [[ $? -ne 0 ]]; then
+if [ $? -ne 0 ]; then
   exit 1
 fi
 
diff --git a/venv.sh b/venv.sh
index aa230992e..577283b46 100755
--- a/venv.sh
+++ b/venv.sh
@@ -1 +1,3 @@
+#!/bin/sh
+
 python3.8 -m venv .venv