Skip to content

Latest commit

 

History

History
83 lines (50 loc) · 6.76 KB

cran-comments.md

File metadata and controls

83 lines (50 loc) · 6.76 KB

Resubmission

This is a resubmission. In this version I have tried to make all requested changes as follows:

"You still refer to multiple help pages on Github, e.g. https://radiant-rstats.github.io/docs/radiant.multivariate.pdf."

  • There are no more links to GitHub in the vignette

"You refer to local files (at least "/docs/data/code.html") that will not exist on your users' systems."

  • There are no references to files that are not on the user's system in the vignette

"You still have no examples in your help pages."

  • I have added examples to the help pages. Please note, however, that they are set to 'dontrun' because the functions exported in the radiant package should not be run as a part of automated testing.

I apologize if I missed something or did not provided the expected changes. I'm happy to fix or change whatever is required.

Previous cran-comments

Resubmission

This is a resubmission. In this version I have:

  • Fixed the links in the vignette. Thanks!
  • Radiant is a shiny app and all help associated with its sub-packages (e.g., radiant.data) is available when your run the app (see inst/app/tools/help in 'radiant.data' for its source markdown files). Having access to these help files through the user interface is more convenient than through R or Rstudio help because you also see it directly in the browser. See https://youtu.be/9qAQio9Hb7k?t=53 for an illustration. Note that users have acces to these helpfiles even if they are offline (i.e., they are part of the radiant packages).
  • I still have links to the Report and Code page on github in the vignette. These are not function manuals but illustrate how to use the shiny user interface.
  • For reference, maybe it is usefull to mention that the structure of the radiant package is somewhat similar to the recently released 'tidyverse' package that pools functionality across several packages
  • I now show help(package = radiant.data) rather than the github links to the manuals. I hope that is what you were looking for
  • There are no examples because the package is an rstudio addin and a shiny app. The UI code is in inst/app and must be tested interactively. The code in R/ is for running and updating the application and is only used in interactive sessions. In sum, testing, including examples, must be done by the package maintainer and the end-user. The analysis code used as part of the different Radiant menu's is in the packages radiant.data, radiant.design, radiant.basics, radiant.model, and radiant.multivariate that I recently submitted to CRAN and is tested there.

Previous cran-comments

Resubmission

This is a resubmission. In this version I have:

  • added a vignette to document the package

Previous cran-comments

Resubmission

  • I was already using R 3.3.1 for the previous submissions and (re-)building and knitting the vignette worked fine. I did various searches online and, as far as I can tell, I followed the appropriate devtools process. The message continued to show up however. I asked for additional guidance but didn't receive any and so I decided to remove the vignette to avoid wasting more CRAN time. Also, the text that was in the vignette is also available on the Radiant documentation site at the following link: https://radiant-rstats.github.io/docs/programming.html
  • Radiant is an rstudio addin and a shiny app. The UI code is in inst/app and must be tested interactively. The code in R/ is for running and updating the application and is only used in interactive sessions. In sum, testing, including examples, must be done by the package maintainer and the end-user. The analysis code used as part of the different Radiant menu's is in the packages radiant.data, radiant.design, radiant.basics, radiant.model, and radiant.multivariate that I recently submitted to CRAN and is tested there.

Resubmission

This is a resubmission. In this version I have:

  • removed the vignette to eliminate the "Package has a VignetteBuilder field but no prebuilt vignette index" note
  • added tests to avoid "checking for code which exercises the package ... WARNING No examples, no tests, no vignettes" warning

Previous cran-comments

This is a resubmission. In this version I have:

  • Removed the offending URL.
  • Used single quotes for R package names in the Description
  • I did various searches online and, as far as I can tell, I am following the appropriate devtools process (FYI I'm using devtools 1.12.0) and (re-)building and knitting the vignette during the build process works fine. Could you perhaps provide additional guidance about how one might even fix "Package has a VignetteBuilder field but no prebuilt vignette index."? Should the submission contain an INDEX file? If so, could you point to an example? Would it be appropriate to make a pdf of the vignette and submit that?
  • If no additional guidance is available I will remove the vignette as the same document is available at the following link: https://radiant-rstats.github.io/docs/programming.html. However, that will lead to the warning "checking for code which exercises the package ... WARNING No examples, no tests, no vignettes". As previously stated "Radiant is an rstudio addin and a shiny app. The UI code is in inst/app and must be tested interactively. The code in R/ is for running and updating the application and is only used in interactive sessions. In sum, testing must be done by the package maintainer and the end-user. The analysis code used as part of Radiant is in the packages radiant.data, radiant.design, radiant.basics, radiant.model, and radiant.multivariate that I recently submitted to CRAN and is tested there." Please advice. Thanks.

Resubmission

This is a resubmission. In this version I have:

  • I was already using R 3.3.1 for the previous submission and (re-)building and knitting the vignette works fine. I did various searches online and, as far as I can tell, I am following the appropriate devtools process. If the message still shows up I must not fully understand the pre-built index issue. FYI I'm using devtools 1.12.0.
  • Changed the Description field so it does not start with the package name
  • Radiant is an rstudio addin and a shiny app. The UI code is in inst/app and must be tested interactively. The code in R/ is for running and updating the application and is only used in interactive sessions. In sum, testing must be done by the package maintainer and the end-user. The analysis code used as part of Radiant is in the packages radiant.data, radiant.design, radiant.basics, radiant.model, and radiant.multivariate that I recently submitted to CRAN and is tested there.

Test environments

  • local OS X install, R 3.3.1
  • local Windows install, R 3.3.1
  • ubuntu 12.04 (on travis-ci), R 3.3.1
  • win-builder (devel and release)

R CMD check results

There were no ERRORs.

There was 1 NOTE: New submission. This package was archived.