Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux #247

Closed
joelgombin opened this issue Nov 22, 2017 · 5 comments
Closed

Linux #247

joelgombin opened this issue Nov 22, 2017 · 5 comments
Labels
admin:Duplicate This issue is a duplicate of another env:Linux This issue is related to running Data Curator on Linux f:Feature-request This issue is a request for a new feature
Milestone

Comments

@joelgombin
Copy link

Is there anyway to use data curator on a Linux distro (apart from using a VM, wine etc.)?

@Stephen-Gates
Copy link
Contributor

Hi @joelgombin,
Developing a Linux distribution is not in our plans. All I can suggest is exploring the Electron docs for clues on how you could do the build on your computer. If you work it out, a PR is very welcome :-)

@Stephen-Gates Stephen-Gates added env:Linux This issue is related to running Data Curator on Linux f:Feature-request This issue is a request for a new feature Help wanted We'd love your help with this issue or pull request labels Nov 22, 2017
@Stephen-Gates Stephen-Gates added this to the Backlog milestone Nov 22, 2017
@chris48s
Copy link

In principle electron apps are cross-platform. If I check out the repo on linux the application will run in dev mode:

git clone https://github.com/ODIQueensland/data-curator.git
cd data-curator/
yarn install
yarn run dev

Given the application launches under linux, there shouldn't be much of a barrier to producing a linux binary of some description, especially given data curator removes the dependency on travelling ruby/csvlint (which was one of the things that required some fiddling to get the builds to work cross-platform in comma chameleon). Attempting to runyarn build on linux fails with Error: Icon set directory /bla/bla/bla/build/icons doesn't contain icons. It may be that adding an icon in the correct format is the only thing you need to do in order to build a linux binary.

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Nov 26, 2017

Great! Thanks for investigating @chris48s.

I've added icons as recommended in electron builder doco.
Let me know if that works or if you need more.

cc: @joelgombin

Stephen-Gates added a commit that referenced this issue Nov 26, 2017
@chris48s
Copy link

Yep - I've just checked out the latest version. yarn build now runs correctly. 👍 By default it produces an AppImage, but it seems like its fairly easy to configure electron-builder to produce other package formats: https://www.electron.build/configuration/linux

I'm not sure on your process for packaging a release, but given you've got a build process which can build a linux binary it might be nice to include one in future releases.

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented May 31, 2019

Closing in favour of #830

@Stephen-Gates Stephen-Gates added the admin:Duplicate This issue is a duplicate of another label May 31, 2019
@Stephen-Gates Stephen-Gates removed Help wanted We'd love your help with this issue or pull request priority:Low labels May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin:Duplicate This issue is a duplicate of another env:Linux This issue is related to running Data Curator on Linux f:Feature-request This issue is a request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants