From f6ee331f912311d042087ea04a205a7d9b7ab6fd Mon Sep 17 00:00:00 2001 From: Steffengreiner Date: Fri, 3 Nov 2023 15:28:20 +0100 Subject: [PATCH] Update JD according to Code Review --- .../folders/nanopore/Fast5SkipFolder.groovy | 2 +- .../folders/nanopore/Pod5FailFolder.groovy | 2 +- .../folders/nanopore/Pod5SkipFolder.groovy | 2 +- .../OxfordNanoporeInstrumentOutputDoradoMinimal.groovy | 10 +++++----- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Fast5SkipFolder.groovy b/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Fast5SkipFolder.groovy index e72827d62..9fe46e9cf 100644 --- a/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Fast5SkipFolder.groovy +++ b/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Fast5SkipFolder.groovy @@ -6,7 +6,7 @@ import life.qbic.datamodel.datasets.datastructure.folders.DataFolder /** * A special case of a DataFolder, its name is always fast5_skip. * - * Its children field contains either a list of type List + * Its children field contains a list of type List * */ class Fast5SkipFolder extends DataFolder { diff --git a/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Pod5FailFolder.groovy b/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Pod5FailFolder.groovy index ae665f199..b1cbdc934 100644 --- a/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Pod5FailFolder.groovy +++ b/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Pod5FailFolder.groovy @@ -3,7 +3,7 @@ package life.qbic.datamodel.datasets.datastructure.folders.nanopore import life.qbic.datamodel.datasets.datastructure.folders.DataFolder /** - * A special case of a DataFolder, its name contains always pod5_fail. + * A special case of a DataFolder, its name is always pod5_fail. * * Its children field contains either a list of type List or List * diff --git a/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Pod5SkipFolder.groovy b/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Pod5SkipFolder.groovy index 3a606b944..fdd66ad0e 100644 --- a/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Pod5SkipFolder.groovy +++ b/src/main/groovy/life/qbic/datamodel/datasets/datastructure/folders/nanopore/Pod5SkipFolder.groovy @@ -6,7 +6,7 @@ import life.qbic.datamodel.datasets.datastructure.folders.DataFolder /** * A special case of a DataFolder, its name is always pod5_skip. * - * Its children field contains either a list of type List + * Its children field contains a list of type List * */ class Pod5SkipFolder extends DataFolder { diff --git a/src/main/groovy/life/qbic/datamodel/instruments/OxfordNanoporeInstrumentOutputDoradoMinimal.groovy b/src/main/groovy/life/qbic/datamodel/instruments/OxfordNanoporeInstrumentOutputDoradoMinimal.groovy index 3dd4af1f7..fcee2f0e8 100644 --- a/src/main/groovy/life/qbic/datamodel/instruments/OxfordNanoporeInstrumentOutputDoradoMinimal.groovy +++ b/src/main/groovy/life/qbic/datamodel/instruments/OxfordNanoporeInstrumentOutputDoradoMinimal.groovy @@ -2,7 +2,7 @@ package life.qbic.datamodel.instruments /** - * Represents the Nanopore instrument output data structure schema. + * Represents the Nanopore instrument output data structure schema generated by employing the dorado basecaller with Pod5Files. * * The original schema is defined in as resource and is * referenced here, wrapped in a Groovy class for reference @@ -11,9 +11,9 @@ package life.qbic.datamodel.instruments */ class OxfordNanoporeInstrumentOutputDoradoMinimal { - private static final String SCHEMA_PATH = "/schemas/nanopore-instrument-output_minimal_dorado.schema.json" + private static final String SCHEMA_PATH = "/schemas/nanopore-instrument-output_minimal_dorado.schema.json" - static InputStream getSchemaAsStream() { - return OxfordNanoporeInstrumentOutputDoradoMinimal.getResourceAsStream(SCHEMA_PATH) - } + static InputStream getSchemaAsStream() { + return OxfordNanoporeInstrumentOutputDoradoMinimal.getResourceAsStream(SCHEMA_PATH) + } }