Skip to content

Commit

Permalink
Update JD according to Code Review
Browse files Browse the repository at this point in the history
  • Loading branch information
Steffengreiner committed Nov 3, 2023
1 parent 87eb244 commit f6ee331
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import life.qbic.datamodel.datasets.datastructure.folders.DataFolder
/**
* A special case of a DataFolder, its name is always fast5_skip.
*
* Its children field contains either a list of type List<Fast5Files>
* Its children field contains a list of type List<Fast5Files>
*
*/
class Fast5SkipFolder extends DataFolder {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package life.qbic.datamodel.datasets.datastructure.folders.nanopore
import life.qbic.datamodel.datasets.datastructure.folders.DataFolder

/**
* A special case of a DataFolder, its name contains always pod5_fail.
* A special case of a DataFolder, its name is always pod5_fail.
*
* Its children field contains either a list of type List<Pod5Files> or List<Pod5Folder>
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import life.qbic.datamodel.datasets.datastructure.folders.DataFolder
/**
* A special case of a DataFolder, its name is always pod5_skip.
*
* Its children field contains either a list of type List<Pod5Files>
* Its children field contains a list of type List<Pod5Files>
*
*/
class Pod5SkipFolder extends DataFolder {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package life.qbic.datamodel.instruments


/**
* Represents the Nanopore instrument output data structure schema.
* Represents the Nanopore instrument output data structure schema generated by employing the dorado basecaller with Pod5Files.
*
* The original schema is defined in as resource and is
* referenced here, wrapped in a Groovy class for reference
Expand All @@ -11,9 +11,9 @@ package life.qbic.datamodel.instruments
*/
class OxfordNanoporeInstrumentOutputDoradoMinimal {

private static final String SCHEMA_PATH = "/schemas/nanopore-instrument-output_minimal_dorado.schema.json"
private static final String SCHEMA_PATH = "/schemas/nanopore-instrument-output_minimal_dorado.schema.json"

static InputStream getSchemaAsStream() {
return OxfordNanoporeInstrumentOutputDoradoMinimal.getResourceAsStream(SCHEMA_PATH)
}
static InputStream getSchemaAsStream() {
return OxfordNanoporeInstrumentOutputDoradoMinimal.getResourceAsStream(SCHEMA_PATH)
}
}

0 comments on commit f6ee331

Please sign in to comment.