Show toast on measurement interaction #981
Conversation
There was a problem hiding this comment.
Heya @sven1103! Awesome Implementation, i have a minor nitpick concering the toast message but overall it looks awesome 👍
...src/main/java/life/qbic/datamanager/views/projects/project/measurements/MeasurementMain.java
Outdated
Show resolved
Hide resolved
| context.projectId().orElseThrow()); | ||
| pendingToast = messageFactory.pendingTaskToast("task.in-progress", new Object[]{ | ||
| "Update of #%d measurements".formatted(measurementData.size())}, |
There was a problem hiding this comment.
This can be confusing in the pooling context, since it will show the number of rows which are updated but not the number of unique measurements.
There was a problem hiding this comment.
What do you suggest instead?
There was a problem hiding this comment.
One way could be to filter the number of measurementIds via the distinct method to ensure only unique measurements are counted and then provide that number within the toast message.
There was a problem hiding this comment.
so straight forward, love it. will do
| } else { | ||
| completableFuture = measurementService.registerAll(upload.measurementMetadata(), | ||
| context.projectId().orElseThrow()); | ||
| pendingToast = messageFactory.pendingTaskToast("task.in-progress", new Object[]{ | ||
| "Registration of #%d measurements".formatted(upload.measurementMetadata().size())}, |
There was a problem hiding this comment.
This can be confusing in the pooling context, since it will show the number of rows which are registered but not the number of unique measurements.
There was a problem hiding this comment.
What do you suggest instead?
Co-authored-by: Steffengreiner <[email protected]>
# Conflicts: # user-interface/src/main/java/life/qbic/datamanager/views/projects/project/measurements/MeasurementMain.java
|
@Steffengreiner want to give it another try? |
|
Displays pending registration toasts, finished toasts and toasts for update + deletion of measurement entities.
Toasts are yummie.