Instrument property in proteomics domain is not precise #786
Assignees
Labels
Comments
sven1103
added
enhancement
|
No need to change instrument for NGS (@oquendoM) |
sven1103
added
core
|
This issue is stale because it has been open for 30 days with no activity. |
KochTobi
added a commit
that referenced
this issue
Sep 16, 2024
Fixes the edit case and renames instrument to MS device fixes #786
KochTobi
added a commit
that referenced
this issue
Sep 17, 2024
* WIP * wip * make it work * Extract behaviour * remove unused method * Adapt proteomics template Fixes the edit case and renames instrument to MS device fixes #786 * Make ngs row creation simpler Uses the enum and enhanced switch to make sure all columns are covered and removes complexity. * remove duplicate row creation for ngs * Rename `Instrument` to `MS Device` in template * Fix column name * Fix sheet locking Excel protected the visible sheet. I do not know why and can only speculate that some reordering was not complete. Creating the hidden sheet second solves the issue. * replace instrument by ms device for proteomics * correct spelling * fix jpa access * solves #747 add technical replicate * fix constructors in tests * use correct methods * Fix wrong imports Co-authored-by: steffengreiner <[email protected]> * move test Co-authored-by: steffengreiner <[email protected]> * Add QBIC_SAMPLE_ID Co-authored-by: steffengreiner <[email protected]> --------- Co-authored-by: steffengreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What are you missing?
For users the property "instrument" when registering measurements is not clear, since it can be the LC system, the mass spec device, or both.
What we actually expect, is the ms device.
Why do you need a solution?
It is unclear for the users what is expected.
Ideas
Maybe just call it MS device, and be precise.
Code of Conduct
The text was updated successfully, but these errors were encountered: