Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate technical feasability of TIB terminology service integration for ontology terms #784

Closed
1 task done
sven1103 opened this issue Aug 14, 2024 · 3 comments · Fixed by #785
Closed
1 task done
Assignees
Labels
core Feature or fix task considered to be in the core product enhancement New feature or request

Comments

@sven1103
Copy link
Contributor

What are you missing?

Our terminology terms, e.g. for mass spec devices (see #734) need to be updated regularly to support recently added terms. However, the maintenance effort is moderate, and in case of #734 also frustrating, when file formats of ontologies suddenly break.

At the same time, the availability of recent terms is a requirement of our service portfolio. If we cannot hold the promise, why are we enforcing ontology terms in the first place.

Why do you need a solution?

I would like to evaluate the TIB terminology service API and the technical feasibility of integration, especially with Vaadin's lazy loading data provider feature.

Ideas

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@sven1103 sven1103 added enhancement New feature or request triage An issue that is in discussion to be either scheduled for implepmentation or denied labels Aug 14, 2024
@sven1103 sven1103 added core Feature or fix task considered to be in the core product and removed triage An issue that is in discussion to be either scheduled for implepmentation or denied labels Aug 14, 2024
@sven1103
Copy link
Contributor Author

Ok, given that the both the Query class in Vaadin and the TIB terminology service API support page size (or rows), limit and offset (page).
The response times are fast (<50ms), and with the filtering for provided ontologies, i think we should give it a try.

@sven1103
Copy link
Contributor Author

sven1103 commented Aug 14, 2024

  • Define a terminology service
  • Define a terminology repository interface, masking the implementation details of the HTTP REST API interaction and result object conversion
  • Implement terminology repository
  • Exchange ontology service for specimen, analyte and measurement device

KochTobi added a commit that referenced this issue Aug 19, 2024
…bility-of-tib-terminology-service-integration-for-ontology-terms
sven1103 added a commit that referenced this issue Aug 20, 2024
…bility-of-tib-terminology-service-integration-for-ontology-terms
@Shraddha0903
Copy link

Shraddha0903 commented Aug 20, 2024

UI Suggestion for the pre-selection of categories before the search:

Ontology Search with Preselect-2

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Feature or fix task considered to be in the core product enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants