Use Cirq Transforms for Gate Decomposition (#93) #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arulandu
changed the title
ryanhill1
requested changes
Jan 9, 2025
| @@ -40,17 +95,17 @@ def test_convert_gridqubits_to_linequbits(gridqubit_circuit): | |||
| linequbit_circuit = preprocess_circuit(gridqubit_circuit) | |||
| for qubit in linequbit_circuit.all_qubits(): | |||
| assert isinstance(qubit, cirq.LineQubit), "Qubit is not a LineQubit" | |||
| assert np.allclose( | |||
| linequbit_circuit.unitary(), gridqubit_circuit.unitary() | |||
| _assert_allclose_up_to_global_phase( | |||
There was a problem hiding this comment.
qbraid is already a test dependency so you can just use qbraid.interface.assert_allclose_up_to_global_phase instead of copying over those same funcs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Use
optimize_for_target_gatesetinstead of the naivecirq.decompose_oncewhen decomposing circuits to a given gateset. Closes #93.