Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly without effect #141

Open
nwittler opened this issue Sep 10, 2021 · 0 comments
Open

Possibly without effect #141

nwittler opened this issue Sep 10, 2021 · 0 comments
Labels
code-quality General code quality related issues and PRs

Comments

@nwittler
Copy link
Collaborator

nwittler commented Sep 10, 2021

c3/c3/signal/gates.py

Lines 106 to 115 in 2b4625f

ideal_gate = insert_mat_kron(
[2] * len(dims), # we compare to the computational basis
targets,
[self.ideal],
)
if index:
ideal_gate = tf_project_to_comp(
ideal_gate, dims=[2] * len(dims), index=index
)

Looks like when index is not None this code has no effect, as the second statement reverses the first.

@nwittler nwittler added the code-quality General code quality related issues and PRs label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality General code quality related issues and PRs
Projects
None yet
Development

No branches or pull requests

1 participant