Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyGithub get_emails now returns a named tuple #409

Open
DamianZaremba opened this issue Jun 24, 2021 · 1 comment · May be fixed by #410
Open

PyGithub get_emails now returns a named tuple #409

DamianZaremba opened this issue Jun 24, 2021 · 1 comment · May be fixed by #410
Assignees
Labels

Comments

@DamianZaremba
Copy link

DamianZaremba commented Jun 24, 2021

Since PyGithub/PyGithub#1890 get_emails is now a named tuple rather than a dict which is causing

Traceback (most recent call last):
  File "/tmp/bin/pyup", line 8, in <module>
    sys.exit(main())
  File "/tmp/lib/python3.9/site-packages/click/core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "/tmp/lib/python3.9/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/tmp/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmp/lib/python3.9/site-packages/click/core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "/tmp/lib/python3.9/site-packages/pyup/cli.py", line 50, in main
    bot.update(branch=branch, initial=initial)
  File "/tmp/lib/python3.9/site-packages/pyup/bot.py", line 123, in update
    self.apply_updates(
  File "/tmp/lib/python3.9/site-packages/pyup/bot.py", line 197, in apply_updates
    pull_request = self.commit_and_pull(
  File "/tmp/lib/python3.9/site-packages/pyup/bot.py", line 420, in commit_and_pull
    new_sha = self.provider.create_commit(
  File "/tmp/lib/python3.9/site-packages/pyup/providers/github.py", line 167, in create_commit
    extra_kwargs["committer"] = self.get_committer_data(committer)
  File "/tmp/lib/python3.9/site-packages/pyup/providers/github.py", line 195, in get_committer_data
    if item["primary"]:
TypeError: tuple indices must be integers or slices, not str

Pinning PyGithub to 1.54.0.1 enables pyup to function as expected.

@DamianZaremba DamianZaremba linked a pull request Jun 24, 2021 that will close this issue
@yeisonvargasf yeisonvargasf self-assigned this Jul 22, 2022
@yeisonvargasf
Copy link
Member

Thanks for the report, it will be handled in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants