Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_hashes is bogus #407

Open
cblegare opened this issue Apr 30, 2021 · 2 comments
Open

get_hashes is bogus #407

cblegare opened this issue Apr 30, 2021 · 2 comments
Assignees
Labels

Comments

@cblegare
Copy link

Hello there!

I'm trying out the bot before even considering the service. I have a requirements.txt file with hashes.

I get the following error

Update cryptography to 3.4.7:   0%|                                                                                                                                                                                                                   | 0/15 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "/home/chabou1/git/gitlab.com/exfo/products/tandm/basecamp/cloud/admin/.venv/bin/pyup", line 8, in <module>
    sys.exit(main())

...

  File "/home/me/project/.venv/lib/python3.8/site-packages/pyup/requirements.py", line 473, in get_hashes
    return data["hashes"]
KeyError: 'hashes'

And I most likely found a bug in https://github.com/pyupio/pyup/blob/master/pyup/requirements.py#L462-L473

Also, this function looks like is mocked in test, not tested itself. I might have missed something...

@cblegare
Copy link
Author

cblegare commented Apr 30, 2021

PR started last year: #392

@cblegare cblegare closed this as completed May 1, 2021
@cblegare
Copy link
Author

cblegare commented May 1, 2021

I there are no issue about this, only a PR, so I reopen

@cblegare cblegare reopened this May 1, 2021
@cblegare cblegare changed the title get_hashes get_hashes is bogus May 1, 2021
@yeisonvargasf yeisonvargasf self-assigned this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants