Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyup incorrectly updated a symlink instead of the actual file #360

Open
karenc opened this issue Aug 30, 2019 · 0 comments
Open

Pyup incorrectly updated a symlink instead of the actual file #360

karenc opened this issue Aug 30, 2019 · 0 comments
Labels
bug considering Under consideration

Comments

@karenc
Copy link

karenc commented Aug 30, 2019

We enabled pyup on one of our repositories that have requirements.txt that are symlinks. It looks something like this:

prod_envs/requirements.txt
prod/requirements.txt -> ../prod_envs/requirements.txt
staging/requirements.txt -> ../prod_envs/requirements.txt

So prod/requirements.txt and staging/requirements.txt both point to prod_envs/requirements.txt. We wanted staging and prod to have the same versions, so we symlinked them to the same file.

What happened was pyup-bot created a commit like this:

- ../prod_envs/requirements.txt
+ Jinja2==2.10.1
+ urllib3==1.25.3

So it's creating a symlink to Jinja2==2.10.1\nurllib3==1.25.3\n and of course that's invalid.

I expect pyup-bot to only update prod_envs/requirements.txt.

(As a workaround, I think I'll configure the bot to not update those symlinked requirements.txt... 🤔)

karenc added a commit to openstax/cnx-deploy that referenced this issue Aug 31, 2019
pyup-bot incorrectly updates a symlink instead of the actual file (see
pyupio/pyup#360) causing the symlink to break.
As a workaround, just configure pyup to not update those files.
karenc added a commit to openstax/cnx-deploy that referenced this issue Aug 31, 2019
pyup-bot incorrectly updates a symlink instead of the actual file (see
pyupio/pyup#360) causing the symlink to break.
As a workaround, just configure pyup to not update those files.
@rafaelpivato rafaelpivato added bug considering Under consideration labels Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug considering Under consideration
Projects
None yet
Development

No branches or pull requests

2 participants