Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mounts argument to more utils components #786

Open
schmidt-ai opened this issue Nov 1, 2023 · 1 comment · May be fixed by #787
Open

Add mounts argument to more utils components #786

schmidt-ai opened this issue Nov 1, 2023 · 1 comment · May be fixed by #787
Assignees
@schmidt-ai

Comments

@schmidt-ai
Copy link
Contributor

schmidt-ai commented Nov 1, 2023 •
edited
Loading

Description

The python, copy, and maybe even the touch util components could benefit from having a mounts argument like the sh util does.

Motivation/Background

It's a slight convenience improvement to these utils because they might be used for dealing with e.g. mounted EFS volumes.

Detailed Proposal

Expand the signature of these util method definitions to include a mounts argument, and pass it into the corresponding Role constructor.

Alternatives

Wrap stuff in a call to utils.sh with your mounts.

Additional context/links

Happy to contribute!
@kiukchung
Copy link
Collaborator

Sounds reasonable. Looking forward to the PR. Thanks!

@schmidt-ai schmidt-ai linked a pull request Nov 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schmidt-ai schmidt-ai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mount args to some utils components schmidt-ai/torchx
2 participants
@kiukchung @schmidt-ai