New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update config defaults dataset.packed and log_peak_memory_stats #1732

Open

felipemello1 opened this issue Oct 1, 2024 · 0 comments

Labels

community help wanted

Contributor

felipemello1 commented Oct 1, 2024 •

edited

Loading

Most configs dont have dataset.packed exposed. We should set it to:

dataset:
packed=False # Set to true for great speed ups

Also, we dont log peak memory by default. If it has no impact in TPS, we should set it to True

log_peak_memory_stats=True

also add compile=False to configs that dont have them

felipemello1 added the community help wanted label

krammnic mentioned this issue

Expose packed: False, set log_peak_memory_stats: True, set compile: False #1872

Merged

13 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment