Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when finetuning pretrained models with lora+chat template, embeddings are not updated #1725

Open
felipemello1 opened this issue Sep 30, 2024 · 0 comments
Open

when finetuning pretrained models with lora+chat template, embeddings are not updated #1725

felipemello1 opened this issue Sep 30, 2024 · 0 comments

Comments

@felipemello1
Copy link
Contributor

For context: https://fb.workplace.com/groups/8194229833921360/posts/8931199086891094/?comment_id=8932594843418185

quick fix: raise error if lora + chat + pretrained model
better fix: raise an error + instruct to finetune the embeddings also
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felipemello1