Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust metadata serialization #97

Open
NicolasHug opened this issue Jul 22, 2024 · 0 comments
Open

More robust metadata serialization #97

NicolasHug opened this issue Jul 22, 2024 · 0 comments

Comments

@NicolasHug
Copy link
Member

To serialize the container/stream metadata to go from C++ to Python, we manually create a JSON string in the C++ code and parse that in Python to get a dict.

We should try to find a more robust way to do that. There are a few alternatives, but ultimately we are limited to what custom ops allow us to return. Some potential alternatives:

  • use a proper JSON library (in C++)
  • pack all the info into tensors.
  • If we're OK to drop the compile/export support for metadata, we could just bind the C++ structs to Python with pybind11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant