From af6dd279b1f574c5cba2fc9db2e1233ed4001ce7 Mon Sep 17 00:00:00 2001 From: atalman Date: Fri, 17 Jan 2025 10:59:33 -0800 Subject: [PATCH 1/2] Update wheel binary size valuidations --- ...ml => validate-pypi-wheel-binary-size.yml} | 19 +++++++++++++++---- .../validate-repackaged-binary-sizes.yml | 1 + 2 files changed, 16 insertions(+), 4 deletions(-) rename .github/workflows/{validate-nightly-pypi-wheel-binary-size.yml => validate-pypi-wheel-binary-size.yml} (55%) diff --git a/.github/workflows/validate-nightly-pypi-wheel-binary-size.yml b/.github/workflows/validate-pypi-wheel-binary-size.yml similarity index 55% rename from .github/workflows/validate-nightly-pypi-wheel-binary-size.yml rename to .github/workflows/validate-pypi-wheel-binary-size.yml index 24fffc16eb..53a833ae2d 100644 --- a/.github/workflows/validate-nightly-pypi-wheel-binary-size.yml +++ b/.github/workflows/validate-pypi-wheel-binary-size.yml @@ -1,16 +1,27 @@ -name: Validate Nightly PyPI Wheel Binary Size +name: Validate PyPI Wheel Binary Size on: pull_request: paths: - - .github/workflows/validate-nightly-pypi-wheel-binary-size.yml + - .github/workflows/validate-pypi-wheel-binary-size.yml workflow_dispatch: + inputs: + channel: + description: "Channel to use (nightly, test)" + required: true + type: choice + default: test + options: + - nightly + - test schedule: # At 2:30 pm UTC (7:30 am PDT) - cron: "30 14 * * *" jobs: - nightly-pypi-binary-size-validation: + pypi-binary-size-validation: runs-on: ubuntu-latest + env: + CHANNEL: ${{ inputs.channel || 'nightly' }} steps: - name: Checkout uses: actions/checkout@v3 @@ -22,5 +33,5 @@ jobs: - name: Run validation run: | python tools/binary_size_validation/binary_size_validation.py \ - --url https://download.pytorch.org/whl/nightly/cu121/torch/ \ + --url https://download.pytorch.org/whl/${CHANNEL}/cu124/torch/ \ --include "linux" --only-latest-version --threshold 750 diff --git a/.github/workflows/validate-repackaged-binary-sizes.yml b/.github/workflows/validate-repackaged-binary-sizes.yml index e819465a26..6325aff29f 100644 --- a/.github/workflows/validate-repackaged-binary-sizes.yml +++ b/.github/workflows/validate-repackaged-binary-sizes.yml @@ -12,6 +12,7 @@ name: Validate manywheel binaries # * optionally upload the repackaged binaries as artifacts (for debug or promotion) on: + workflow_dispatch: pull_request: paths: - .github/workflows/validate-repackaged-binary-sizes.yml From 6c7049db8d91b31b71196fb1572a44a711274a21 Mon Sep 17 00:00:00 2001 From: atalman Date: Fri, 17 Jan 2025 11:16:22 -0800 Subject: [PATCH 2/2] fix_lint --- .github/workflows/validate-pypi-wheel-binary-size.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/validate-pypi-wheel-binary-size.yml b/.github/workflows/validate-pypi-wheel-binary-size.yml index 53a833ae2d..c92961d030 100644 --- a/.github/workflows/validate-pypi-wheel-binary-size.yml +++ b/.github/workflows/validate-pypi-wheel-binary-size.yml @@ -32,6 +32,7 @@ jobs: pip3 install -r tools/binary_size_validation/requirements.txt - name: Run validation run: | + # shellcheck disable=SC2086 python tools/binary_size_validation/binary_size_validation.py \ --url https://download.pytorch.org/whl/${CHANNEL}/cu124/torch/ \ --include "linux" --only-latest-version --threshold 750