Skip to content

Commit

Permalink
[bot] Remove flaky detection for flaky across jobs (#4693)
Browse files Browse the repository at this point in the history
Currently buggy due to tests jumping from shard to shard.
  • Loading branch information
clee2000 authored Nov 2, 2023
1 parent b3f4379 commit 51a5a9f
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions torchci/pages/api/flaky-tests/disable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,21 +36,17 @@ async function disableFlakyTestsAndReenableNonFlakyTests() {
octokit,
flakyTests,
flakyTestsAcrossFileReruns,
flakyTestsAcrossJobs,
issues,
disabledNonFlakyTests,
] = await Promise.all([
getOctokit(owner, repo),
fetchFlakyTests(`${NUM_HOURS}`),
fetchFlakyTestsAcrossFileReruns(`${NUM_HOURS}`),
fetchFlakyTestsAcrossJobs(`${NUM_HOURS_ACROSS_JOBS}`), // use a larger time window so we can get more data
fetchIssuesByLabel("skipped"),
fetchDisabledNonFlakyTests(),
]);

const allFlakyTests = flakyTests
.concat(flakyTestsAcrossJobs)
.concat(flakyTestsAcrossFileReruns);
const allFlakyTests = flakyTests.concat(flakyTestsAcrossFileReruns);
// If the test is flaky only on PRs, we should not disable it yet.
const flakyTestsOnTrunk = filterThreshold(
filterOutPRFlakyTests(allFlakyTests)
Expand Down

1 comment on commit 51a5a9f

@vercel
Copy link

@vercel vercel bot commented on 51a5a9f Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.