Skip to content

Commit

Permalink
Merge branch 'master' into hsic
Browse files Browse the repository at this point in the history
  • Loading branch information
kzkadc authored Sep 10, 2024
2 parents 490fdb3 + 653fb9e commit 11fb1a3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions ignite/handlers/mlflow_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,15 +245,15 @@ def __call__(self, engine: Engine, logger: MLflowLogger, event_name: Union[str,
)

# Additionally recheck metric names as MLflow rejects non-valid names with MLflowException
from mlflow.utils.validation import _VALID_PARAM_AND_METRIC_NAMES
from mlflow.utils.validation import validate_param_and_metric_name

metrics = {}
for keys, value in rendered_metrics.items():
key = " ".join(keys)
metrics[key] = value

for key in list(metrics.keys()):
if not _VALID_PARAM_AND_METRIC_NAMES.match(key):
if not validate_param_and_metric_name(key):
warnings.warn(
f"MLflowLogger output_handler encountered an invalid metric name '{key}' that "
"will be ignored and not logged to MLflow"
Expand Down
2 changes: 1 addition & 1 deletion ignite/handlers/wandb_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def __getattr__(self, attr: Any) -> Any:
return getattr(self._wandb, attr)

def close(self) -> None:
self._wandb.finish() # type: ignore[attr-defined]
self._wandb.finish()

def _create_output_handler(self, *args: Any, **kwargs: Any) -> "OutputHandler":
return OutputHandler(*args, **kwargs)
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ tensorboardX
visdom
polyaxon
wandb
mlflow<2.16.0 # https://github.com/pytorch/ignite/issues/3277
mlflow
neptune-client>=0.16.17
tensorboard
torchvision
Expand Down

0 comments on commit 11fb1a3

Please sign in to comment.