Skip to content

Commit ac51368

Browse files
committed
404 if calendar is not found
1 parent a72cedb commit ac51368

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

events/tests/test_views.py

+5
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ def test_event_list(self):
4141
self.assertEqual(response.status_code, 200)
4242
self.assertEqual(len(response.context['object_list']), 1)
4343

44+
url = reverse('events:event_list_past', kwargs={"calendar_slug": 'unexisting'})
45+
response = self.client.get(url)
46+
47+
self.assertEqual(response.status_code, 404)
48+
4449
def test_event_list_past(self):
4550
url = reverse('events:event_list_past', kwargs={"calendar_slug": self.calendar.slug})
4651
response = self.client.get(url)

events/views.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Create your views here.
22
import datetime
33

4+
from django.shortcuts import get_object_or_404
45
from django.utils import timezone
56
from django.views.generic import DetailView, ListView
67

@@ -74,7 +75,7 @@ def get_queryset(self):
7475
def get_context_data(self, **kwargs):
7576
context = super().get_context_data(**kwargs)
7677
context['events_today'] = Event.objects.until_datetime(timezone.now()).filter(calendar__slug=self.kwargs['calendar_slug'])[:2]
77-
context['calendar'] = Calendar.objects.get(slug=self.kwargs['calendar_slug'])
78+
context['calendar'] = get_object_or_404(Calendar, slug=self.kwargs['calendar_slug'])
7879
return context
7980

8081

0 commit comments

Comments
 (0)