From 547b86e46d36e35d1b42ad37df1fe7119db8840a Mon Sep 17 00:00:00 2001 From: Alyssa Coghlan Date: Thu, 6 Jun 2024 17:51:08 +1000 Subject: [PATCH 1/4] PEP 683: mark as Final --- peps/pep-0683.rst | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/peps/pep-0683.rst b/peps/pep-0683.rst index 939317cc943..521caecaa66 100644 --- a/peps/pep-0683.rst +++ b/peps/pep-0683.rst @@ -2,7 +2,7 @@ PEP: 683 Title: Immortal Objects, Using a Fixed Refcount Author: Eric Snow , Eddie Elizondo Discussions-To: https://discuss.python.org/t/18183 -Status: Accepted +Status: Final Type: Standards Track Content-Type: text/x-rst Created: 10-Feb-2022 @@ -13,20 +13,18 @@ Post-History: `16-Feb-2022 `__, Resolution: https://discuss.python.org/t/18183/26 +.. canonical-doc: :term:`reference count` PEP Acceptance Conditions ========================= The PEP was accepted with conditions: -* we must apply the primary proposal - in `Solutions for Accidental De-Immortalization`_ - (reset the immortal refcount in ``tp_dealloc()``) -* types without this may not be immortalized (in CPython's code) -* the PEP must be updated with final benchmark results once - the implementation is finalized -* we will have one last round of discussion about those results at that point - +* the primary proposal in `Solutions for Accidental De-Immortalization`_ + (reset the immortal refcount in ``tp_dealloc()``) was applied +* types without this were not immortalized (in CPython's code) +* the PEP was updated with final benchmark results once + the implementation is finalized (confirming the change is worthwhile) Abstract ======== From 125dd4832d159b4acba8c7191b974855fef187fb Mon Sep 17 00:00:00 2001 From: Alyssa Coghlan Date: Thu, 6 Jun 2024 18:08:24 +1000 Subject: [PATCH 2/4] canonical-doc markup != comment markup --- peps/pep-0683.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/peps/pep-0683.rst b/peps/pep-0683.rst index 521caecaa66..5ff26dcd36c 100644 --- a/peps/pep-0683.rst +++ b/peps/pep-0683.rst @@ -13,7 +13,7 @@ Post-History: `16-Feb-2022 `__, Resolution: https://discuss.python.org/t/18183/26 -.. canonical-doc: :term:`reference count` +.. canonical-doc:: :term:`reference count` PEP Acceptance Conditions ========================= From 662951def8adcae466ac78b7ad029ebe5261eccb Mon Sep 17 00:00:00 2001 From: Alyssa Coghlan Date: Thu, 6 Jun 2024 18:40:08 +1000 Subject: [PATCH 3/4] Content-Type is redundant now Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> --- peps/pep-0683.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/peps/pep-0683.rst b/peps/pep-0683.rst index 5ff26dcd36c..b381c404761 100644 --- a/peps/pep-0683.rst +++ b/peps/pep-0683.rst @@ -4,7 +4,6 @@ Author: Eric Snow , Eddie Elizondo `__, From 698994702e93737bf92382ba6ce62c1109198691 Mon Sep 17 00:00:00 2001 From: Alyssa Coghlan Date: Thu, 6 Jun 2024 19:56:30 +1000 Subject: [PATCH 4/4] Farewell, Emacs config --- peps/pep-0683.rst | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/peps/pep-0683.rst b/peps/pep-0683.rst index b381c404761..80243b8cdc8 100644 --- a/peps/pep-0683.rst +++ b/peps/pep-0683.rst @@ -901,14 +901,3 @@ Copyright This document is placed in the public domain or under the CC0-1.0-Universal license, whichever is more permissive. - - - -.. - Local Variables: - mode: indented-text - indent-tabs-mode: nil - sentence-end-double-space: t - fill-column: 70 - coding: utf-8 - End: