Add tests where command reports errors

Author: rd4398

e2e/test_lint_requirements.sh

@@ -8,10 +8,24 @@ source "$SCRIPTDIR/common.sh"
 
 pass=true
 
-fromager lint-requirements "$SCRIPTDIR/validate_inputs/constraints.txt" "$SCRIPTDIR/validate_inputs/requirements.txt"
+# Test to demonstrate that command works as expected when input files are valid
 
-if [ $? -ne 0 ]; then
-    echo "the input files are not correctly formatted."
+if ! fromager lint-requirements "$SCRIPTDIR/validate_inputs/constraints.txt" "$SCRIPTDIR/validate_inputs/requirements.txt"; then
+    echo "the input files are not correctly formatted." 1>&2
+    pass=false
+fi;
+
+# Test to demonstrate failing of command due to missing input args
+
+if fromager lint-requirements "$SCRIPTDIR/validate_inputs/constraints.txt"; then
+    echo "input arguments are missing for the command" 1>&2
+    pass=false
+fi;
+
+# Test to demonstrate that command reports error for invalid / bad input files
+
+if fromager lint-requirements "$SCRIPTDIR/validate_inputs/constraints.txt" "$SCRIPTDIR/validate_inputs/invalid-requirements.txt"; then
+    echo "input arguments are missing for the command" 1>&2
     pass=false
 fi;
 

e2e/validate_inputs/invalid-requirements.txt

@@ -0,0 +1,5 @@
+# This requirements file is invalid on purpose to test the lint-requirements 
+# command of fromager. Do not attempt to fix this file
+
+foo==
+bar<=

e2e/validate_inputs/requirements.txt

@@ -1,5 +1,5 @@
 # This requirements.txt is used for testing lint_requirements
-# command of fromager an contains examples of packages
+# command of fromager and contains examples of packages
 stevedore==5.2.0
 kfp==2.11.0