logwrap breaks functions

[drnextgis]

Using logwrap breaks functions. When I add @logwrap.logwrap to get_shape function it stops working:

In [1]: from telluric import GeoVector, constants
In [2]: from shapely import geometry
In [3]: from rasterio.crs import CRS
In [4]: poly = geometry.Polygon.from_bounds(4334065.7375318575650454, 5627100.9060072815045714, 4337359.6036174902692437,5630885.4445580849424005)
In [5]: roi = GeoVector(poly, crs=constants.WEB_MERCATOR_CRS)
In [6]: roi.get_shape(CRS({'init': 'epsg:3857'}))
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-6-0be1dd22719f> in <module>()
----> 1 roi.get_shape(CRS({'init': 'epsg:3857'}))

~/sandbox/telluric/env/lib/python3.5/site-packages/logwrap/_log_wrap.cpython-35m-x86_64-linux-gnu.so in logwrap._log_wrap.LogWrap._get_function_wrapper.wrapper()

~/sandbox/telluric/env/lib/python3.5/site-packages/logwrap/_log_wrap.cpython-35m-x86_64-linux-gnu.so in bind_args_kwargs()

~/sandbox/telluric/telluric/telluric/vectors.py in __eq__(self, other)
    437         # otherwise the delegation won't happen
    438         return (
--> 439             self.crs == other.crs
    440             and self._shape.equals(other.get_shape(self.crs))
    441         )

AttributeError: type object '_empty' has no attribute 'crs'

Without @logwrap.logwrap all works as expected.

[penguinolog]

Debugging...

[drnextgis]

Thank you for quick response! All mentioned libraries you can find at PyPI. Decorated function is GeoVector.get_shape from telluric library. Should I provide anything else?

[penguinolog]

No, I found place: __eq__ called for check, that default value not equals to set via parameter, default is signature.empty and __eq__ not check for type and fields:

            self.crs == other.crs
            and self._shape.equals(other.get_shape(self.crs))
        )

I'll make validation safer on logwrap side, but this error means, that GeoVector instances can not be compared with other types (int for example). Normally it should simply return False for any incompatible types.

[penguinolog]

Expect fix on evening

[penguinolog]

Done and released 4.0.2/5.0.1:

Test output at log:

'get_shape'(
    # POSITIONAL_OR_KEYWORD:
    'self'=GeoVector(shape=POLYGON ((4334065.737531858 5627100.906007282, 4334065.737531858 5630885.444558085, 4337359.60361749 5630885.444558085, 4337359.60361749 5627100.906007282, 4334065.737531858 5627100.906007282)), crs=+init=epsg:3857),
    'crs'=CRS({'init': 'epsg:3857'}),
)
DEBUG:logwrap:Done: 'get_shape' with result:
<shapely.geometry.polygon.Polygon object at 0x7f26e76abf60>```

[drnextgis]

Thank you very much, Alexey!

I have one questions related to the library. Now it is not possible to bypass logwrap if current log level is higher then log_level, right? It would be handy if logwrap decorator be able to return original function in this case.

[penguinolog]

No, logwrap just log function call to debug (if not verbose, else info), call function and lor result/crash. No any changes to function and result produced, logger is not re-configured (so if log_level is warning, for example, in logs will be only crash info). If logger is not configured - logwrap not produce any side-effects (except small time lag during data processing and send to logger) вт, 14 авг. 2018 г., 21:09 Denis Rykov <[email protected]>:

…

Thank you very much, Alexey! I have one questions related to the library. Now it is not possible to bypass logwrap if current log level is higher then log_level, right? It would be handy if logwrap decorator be able to return original function in this case. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APSmM52ZbFCy95_G57eJ0ahLgloF6Xw_ks5uQyCFgaJpZM4V76mn> .