From 847f90c55e31805ec4a588ae0d8d4a17713cfdba Mon Sep 17 00:00:00 2001 From: jakkdl Date: Mon, 27 May 2024 17:04:49 +0200 Subject: [PATCH] fix crash when subscripts are in attributes --- flake8_async/visitors/helpers.py | 16 ++++++++++------ tests/eval_files/async120.py | 4 ++++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/flake8_async/visitors/helpers.py b/flake8_async/visitors/helpers.py index f1bf871..be39809 100644 --- a/flake8_async/visitors/helpers.py +++ b/flake8_async/visitors/helpers.py @@ -337,11 +337,15 @@ def build_cst_matcher(attr: str) -> m.BaseExpression: return m.Attribute(value=build_cst_matcher(body), attr=m.Name(value=tail)) -def identifier_to_string(attr: cst.Name | cst.Attribute) -> str: +def identifier_to_string(attr: cst.Name | cst.Attribute) -> str | None: if isinstance(attr, cst.Name): return attr.value - assert isinstance(attr.value, (cst.Attribute, cst.Name)) - return identifier_to_string(attr.value) + "." + attr.attr.value + if not isinstance(attr.value, (cst.Attribute, cst.Name)): + return None + lhs = identifier_to_string(attr.value) + if lhs is None: + return None + return lhs + "." + attr.attr.value def with_has_call( @@ -383,10 +387,10 @@ def with_has_call( assert isinstance(item.item, cst.Call) assert isinstance(res["base"], (cst.Name, cst.Attribute)) assert isinstance(res["function"], cst.Name) + base_string = identifier_to_string(res["base"]) + assert base_string is not None, "subscripts should never get matched" res_list.append( - AttributeCall( - item.item, identifier_to_string(res["base"]), res["function"].value - ) + AttributeCall(item.item, base_string, res["function"].value) ) return res_list diff --git a/tests/eval_files/async120.py b/tests/eval_files/async120.py index 824d151..e952580 100644 --- a/tests/eval_files/async120.py +++ b/tests/eval_files/async120.py @@ -72,3 +72,7 @@ async def foo(): # or any lambda thing my_lambda = lambda: asyncio.create_task(*args) my_lambda(*args) + + # don't crash + + args.nodes[args].append(args)