Fixes behaviour change bug #512

Author: Peter Doggart

CHANGELOG.rst

@@ -35,7 +35,8 @@ Bug Fixes
 
 ::
 
-   * Update Black to 2023 version [peter_doggart]
+   * Update Black to 2023 version [peter-doggart]
+   * Fix minor bug introduced in 1.0.5 that changed the behaviour of how flask-restx propagates exceptions. (#512) [peter-doggart]
 
 .. _section-1.0.5:
 1.0.5

flask_restx/api.py

@@ -685,7 +685,10 @@ def handle_error(self, e):
         # client if a handler is configured for the exception.
         if (
             not isinstance(e, HTTPException)
-            and current_app.config.get("PROPAGATE_EXCEPTIONS", False)
+            and (
+                current_app.config.get("PROPAGATE_EXCEPTIONS")
+                or (current_app.testing or current_app.debug)
+            )
             and not isinstance(e, tuple(self._own_and_child_error_handlers.keys()))
         ):
             exc_type, exc_value, tb = sys.exc_info()

tests/test_errors.py

@@ -325,6 +325,48 @@ def get(self):
         with pytest.raises(Exception):
             client.get("/api/test/")
 
+    def test_default_errorhandler_with_propagate_not_set_but_testing(self, app, client):
+        blueprint = Blueprint("api", __name__, url_prefix="/api")
+        api = restx.Api(blueprint)
+
+        @api.route("/test/")
+        class TestResource(restx.Resource):
+            def get(self):
+                raise Exception("error")
+
+        app.register_blueprint(blueprint)
+
+        app.config["PROPAGATE_EXCEPTIONS"] = None
+        app.testing = True
+
+        # From the Flask docs:
+        # PROPAGATE_EXCEPTIONS
+        # Exceptions are re-raised rather than being handled by the app’s error handlers.
+        # If not set, this is implicitly true if TESTING or DEBUG is enabled.
+        with pytest.raises(Exception):
+            client.get("/api/test/")
+
+    def test_default_errorhandler_with_propagate_not_set_but_debug(self, app, client):
+        blueprint = Blueprint("api", __name__, url_prefix="/api")
+        api = restx.Api(blueprint)
+
+        @api.route("/test/")
+        class TestResource(restx.Resource):
+            def get(self):
+                raise Exception("error")
+
+        app.register_blueprint(blueprint)
+
+        app.config["PROPAGATE_EXCEPTIONS"] = None
+        app.debug = True
+
+        # From the Flask docs:
+        # PROPAGATE_EXCEPTIONS
+        # Exceptions are re-raised rather than being handled by the app’s error handlers.
+        # If not set, this is implicitly true if TESTING or DEBUG is enabled.
+        with pytest.raises(Exception):
+            client.get("/api/test/")
+
     def test_custom_default_errorhandler(self, app, client):
         api = restx.Api(app)