-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.2.0 Release #5586
Comments
#4979 was deemed a duplicate and closed, but it is different in that it represents a 1.1.x -> 1.2.x regression. As far as I can tell, build scripts will be broken by 1.2.0 |
I'd say this: #5529, as big update like this, is good moment to remove 2.7 support. Still working on it though. |
#5633 this should be fixed before release |
#3767 may be really nice to have too. |
Hey folks, My company is very interested in using poetry as part of our python infrastructure. We have been trying poetry internally and feeling really good about it. The problem is that we need to use poetry plugin to support some of our internal pypi set up. So I'm wondering if there is an estimated release date for poetry 1.2.0. Thanks! |
As with most solely voulenteer-driven projects, the answer is unfortunately when it's ready. The 1.2 release is quite big due to our poor release cadence, so this is taking a decent amount of time to cook. We hope to have a RC out in a week or two, and have a final release a week after that. Setbacks like major regressions or complications in the final few blockers may affect that timeline. If you are interested in helping us get over the finish line, we're always looking for additional help. I'd suggest joining our Discord server and asking if there's anything you can help with in #contributing -- in particular, we're still looking for more volunteers for triage, as well as product/release management. |
Thanks for the quick reply. I'll see if I can contribute too. |
Hi there, absolutely love poetry. Would it imply a lot of extra work (wasted volunteer time) to release more beta's while the final release is still blocked? There are several fixes in the master branch which are not in 1.2.0b1, so to use those I would have to install poetry from source, rather than using the install script with --preview. |
@wvzytlyn we do plan on releasing a new beta this week (hopefully). The short answer to your question is, right now it does still take effort to get a new beta out because we need some manual work (changelogs, testing etc). While releasing often might be good, right now due to the amount of folks using 1.2.0b1 in production workflows, it might pose a larger issue if we release with known breakages. Let's keep this issue clear of such discussions. Feel free to ping us on discord or raise discussion on GH. |
As |
I would like to see #5727 fixed. I posted working code in the issue, so now I get to dive in the test cases for solving in order to be a good open source citizen and provide a failing test case. |
See my comments on that issue -- I don't think we're going to call this a blocker, but I would like to see MS Store Python working before we ship 1.2 if it's not going to hold up the whole release. The issue likely lies in the installer which means it can be fixed after release with no additional patch, anyway. |
Fair enough. Thank you for taking a look. |
Could #5811 be added in the nice to haves? |
Some desirable fixes that are currently on the backlog below. Having said which: I would personally be happy to see 1.2.0 cut right now, if we can improve the release cadence - things that don't make 1.2.0 can always go into 1.2.x If there are issues that would help to make the release process faster / easier / more regular: suggest that advertising them prominently in this repository so that folk can chip in and help would be a good move. Anyway these I think just want someone to hit the merge button
This needs a poetry-core release but looks like a good correctness fix And I have a couple of fixes relating to the correctness of |
As someone who interacts with Python novices a lot and introduces them to Poetry, I would ask for the following to be considered for 1.2:
I think that once the new installer becomes default on the website, most users will start using it. The new installer does not add Two paths forward I see:
|
See my answer at your linked discussion question -- in short, I don't mind adding a snippet, though I think a 'copy and paste' Powershell snippet is somewhat problematic as not all Windows users use Powershell. In general, as Poetry is a CLI program we do expect users to have enough wherewithall to Google how to modify their PATH -- on Windows it's a well-documented/known GUI. |
New regression/blocker for 1.2: #6054 |
All the blockers are closed. Ship it! Really: is there anything blocking the release, or is it "just" (yes I know) a question of maintainer time?
|
Added a new blocker that was just discovered -- there is already a PR pending, we are just waiting on tests. |
You folks are awesome. Thank you for the update @neersighted. I can't say how excited I am for the 1.2 release. |
I've been running 1.2.0b3. is there anything else we can do to help test for the release? |
1.2.0rc1 is just around the corner (#6175). Testing it for regressions is welcome. If there are no major issues, the release should follow shortly after. |
1.2.0rc1 is tagged and is in the stabilization phase. The 1.2 branch is created and will be accepting backports for any last-minute issues found with the release candidate. Assuming we don't have any regressions, 1.2.0 will be released next Monday. |
This comment was marked as off-topic.
This comment was marked as off-topic.
A quick status update for those following this issue: We had to release 1.2.0rc2 with some important fixes plus the reintroduction of a removed plugin API. We are shooting for this Wednesday for the final release of 1.2. The related PRs are:
|
We are unlikely to be able to support poetry 1.2.0 on conda-forge unless #5980 gets figured out. conda fundamentally cannot handle circular dependencies. |
This is known and we do not plan to address it as part of 1.2. We have discussed a path for breaking the circular dependency in a way that is compatible with conda-forge and a pleasant user experience, which will start in 1.3 and likely be finalized in 1.4. Please don't let the version numbers scare you, the intention is to release early and often and to minimize the number of backports to help keep project velocity up. 1.2 is something of an aberration but we have a revitalized core team and much more momentum (plus, no pandemic disrupting people's lives). |
@neersighted, okay, thanks. We're already running into packages that can't be built on conda-forge because of not supporting 1.2.0 prereleases so it's good to know that this problem hopefully won't be long lived. |
🚀 Thank you all for the hard work! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Trying to gather the list of actual blockers for 1.2.0 final release. If there is a PR open that absolutely must be included in the 1.2.0 release, please link them here. Issues, unless they are deemed critical (ie. regression that fundamentally breaks workflows), are unlikely to be considered at this stage.
A link and a short note on why you think is important would suffice. If you agree that a linked issue/pr in the comments is important use 👍 else use 👎 to vote.
Let's avoid bike shedding in here so that the maintainers can focus on the signal.
Blockers
These are a subset of the 1.2 Milestone.
poetry plugin
commands with more genericpoetry self
commands #5450Nice to haves
download_file
if in Indicator context #5451--dry-run
option doesn't updatepoetry.lock
foradd
,update
andremove
#5718General Notes
PEP 610 Changes
Due to changes required in #5362, when upgrading from Poetry
1.1
releases, existings environments might see the following "no update" logs. This is because, with1.2.0a1
, we fixed an issue with the executor that wrote incorrect PEP 610 metadata.The text was updated successfully, but these errors were encountered: