Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add localization FitFactory support #7

Open
barentine opened this issue Oct 1, 2020 · 1 comment
Open

add localization FitFactory support #7

barentine opened this issue Oct 1, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@barentine
Copy link
Member

At the moment FitFactories need to be in core PYME to be discovered, yet many in the SMLM community have reasons to develop new/use old fitters, etc., and some have expressed interest in adding their algorithms (e.g. phasor-based localization) to PYME. This would also be a great opportunity to clean things up a bit, tidy up/unify units/offsets/etc. while making the then-legacy fitters available in plugins so people can still easily rerun old routines for reproducibility.

Lessons learned when shimming in the warp-drive fit is that there are quite some units/reference frames which need to be documented well to get everything to play nice/not duplicate computation doing/undoing conversions. This should be considerably smoother now, but would be worth touching up again (I think specifically with the multiview metadata stuff I've used with the AstigGaussGPUFitFR the camera ROI offset is dropped, which is only a problem is you want to go back post facto and re-map localizations to the raw camera frames (outside of the test frame functionality).

@barentine barentine added the enhancement New feature or request label Oct 1, 2020
@barentine
Copy link
Member Author

Addressed in python-microscopy/python-microscopy#1359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant