Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for thousands is wrong in French #191

Closed
enlivn opened this issue Jul 23, 2024 · 3 comments · Fixed by #192
Closed

Translation for thousands is wrong in French #191

enlivn opened this issue Jul 23, 2024 · 3 comments · Fixed by #192
Labels
needs localisation Translations need updating

Comments

@enlivn
Copy link
Contributor

enlivn commented Jul 23, 2024

What did you do?

>>> import humanize as h
>>> print(h.__version__)
4.8.0
>>> h.i18n.activate('fr')
<gettext.GNUTranslations object at 0x1033a9c30>
>>> h.intword(22382)
'22.4 thousand'

What did you expect to happen?

thousand should be mille or milles for plural in French

What actually happened?

prints thousand

What versions are you using?

  • OS: MacOS Sonoma 14.5
  • Python: 3.10.11
  • Humanize: 4.8.0

See code snippet at start of issue.

@hugovk hugovk added the needs localisation Translations need updating label Jul 23, 2024
@hugovk
Copy link
Member

hugovk commented Jul 23, 2024

Looks like we're missing the translation here:

#: src/humanize/number.py:178
msgid "thousand"
msgid_plural "thousand"
msgstr[0] ""
msgstr[1] ""

Would you like to contribute a PR?

@enlivn
Copy link
Contributor Author

enlivn commented Jul 23, 2024

Looks like we're missing the translation here:

#: src/humanize/number.py:178
msgid "thousand"
msgid_plural "thousand"
msgstr[0] ""
msgstr[1] ""

Would you like to contribute a PR?

sure, I can look into it.

@enlivn
Copy link
Contributor Author

enlivn commented Jul 23, 2024

@hugovk just put up #192. Thanks for your quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs localisation Translations need updating
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants