Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make masking more efficient for reduce_to_vector #14

Open
jim22k opened this issue Feb 24, 2023 · 0 comments
Open

Make masking more efficient for reduce_to_vector #14

jim22k opened this issue Feb 24, 2023 · 0 comments

Comments

@jim22k
Copy link
Member

jim22k commented Feb 24, 2023

The mask in reduce_to_vector is a Vector, while the input is a Matrix, making it impossible to apply the mask prior to the operation. If select_by_mask could do vec->matrix broadcasting, the mask could be applied earlier and possibly save compute time.

Alternatively, the mask could be brought into the linalg.generic loop and used to skip entire rows.

The 2nd approach would be faster and simpler if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant