Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Hangman game #1085

Open
1 of 2 tasks
Diabolical5777 opened this issue Aug 13, 2022 · 5 comments
Open
1 of 2 tasks

Update the Hangman game #1085

Diabolical5777 opened this issue Aug 13, 2022 · 5 comments
Labels
category: fun Related to fun and games status: planning Discussing details type: enhancement Changes or improvements to existing features

Comments

@Diabolical5777
Copy link
Contributor

Diabolical5777 commented Aug 13, 2022

Description

In the hangman command, I think it would be nice if modes of "easy", "medium" and "hard" were added, instead of the 4 optional arguments it currently has.

Reasoning

It could make the game more flexible and easier to change it up

Proposed Implementation

By doing def hangman(self, ctx, *args)

Would you like to implement this yourself?

  • I'd like to implement this feature myself
  • Anyone can implement this feature
@Diabolical5777 Diabolical5777 added status: planning Discussing details type: feature Relating to the functionality of the application. labels Aug 13, 2022
@ChrisLovering
Copy link
Member

I think having control over the config directly is quite useful.

So maybe instead we could have an additional optional param for difficulty. This param would set the "default" config for the game, but users could still give the existing params to overwrite that if needed.

IE you could do !hangman easy 4 which would set the min_length to 4 and the other variables to whatever would be considered "easy".

What do you think of that?

@ChrisLovering ChrisLovering added type: enhancement Changes or improvements to existing features category: fun Related to fun and games and removed type: feature Relating to the functionality of the application. labels Aug 17, 2022
@Diabolical5777
Copy link
Contributor Author

Maybe...we can have both? The 3 modes added on to the current implementation of being able to have full control over the generated word?
If we were to do def hangman(self, ctx, *args), we could check the len() passed in, and the type to figure out what the user inputted

@ChrisLovering
Copy link
Member

ChrisLovering commented Aug 17, 2022

Maybe...we can have both?

That's sort of what I was suggesting, with an additional optional param for difficulty.

However, rather than only allowing one or the other, I proposed that we would allow both if the user wanted, having the specific config overwrite the defaults for the difficulty.

@Diabolical5777
Copy link
Contributor Author

Would the amount of times that one of the 4 current optional arguments be a factor that affects the decision? As in, if most of the time, users just use the command without arguments

@GiovanePS
Copy link

I want to do this issue, can I?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: fun Related to fun and games status: planning Discussing details type: enhancement Changes or improvements to existing features
Projects
None yet
Development

No branches or pull requests

3 participants