Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port GitHub code display embed from Python #1079

Open
shenanigansd opened this issue Jul 15, 2022 · 4 comments
Open

Port GitHub code display embed from Python #1079

shenanigansd opened this issue Jul 15, 2022 · 4 comments
Assignees
@TizzySaurus
Labels
area: backend Related to internal functionality and utilities category: utilities Related to utilities status: approved The issue has received a core developer's approval status: stalled Something is blocking further progress type: feature Relating to the functionality of the application.

Comments

@shenanigansd
Copy link
Member

Move the feature that displays the lines of code from GitHub when a link with line numbers is sent from Python to Sir Lancebot

Approved by @Xithrius here: https://discord.com/channels/267624335836053506/635950537262759947/997558518968221696
@shenanigansd shenanigansd added type: feature Relating to the functionality of the application. status: approved The issue has received a core developer's approval labels Jul 15, 2022
@Xithrius
Copy link
Member

I approve here as well.

@TizzySaurus
Copy link
Contributor

For reference, this is the location of said feature.

@TizzySaurus
Copy link
Contributor

@shenanigansd has stated in #dev-contrib that they're not wishing to implement this themselves, so I'd like to claim this. Can I please be assigned?

@TizzySaurus
Copy link
Contributor

NB: This is now waiting on python-discord/bot-core#141, as lancebot is missing certain util functions.

@TizzySaurus TizzySaurus added area: backend Related to internal functionality and utilities status: stalled Something is blocking further progress category: utilities Related to utilities labels Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TizzySaurus TizzySaurus

Labels
area: backend Related to internal functionality and utilities category: utilities Related to utilities status: approved The issue has received a core developer's approval status: stalled Something is blocking further progress type: feature Relating to the functionality of the application.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xithrius @TizzySaurus @shenanigansd