Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ForceReply doesn't work with the new attach argument #87

Open
paolobarbolini opened this issue Jul 19, 2017 · 0 comments
Open

ForceReply doesn't work with the new attach argument #87

paolobarbolini opened this issue Jul 19, 2017 · 0 comments
Labels
E-regression T-bug
Milestone
botogram 0.4.1

Comments

@paolobarbolini
Copy link
Member

In commit 533a81c the Buttons and the ButtonsRow class were added without implementing the BaseObject class which already had the serialize method for serializing the data to json, instead a new _serialize_attachment method was used without adding it to the ForceReply class, resulting in the impossibility of using ForceReply in botogram 1.0 when the deprecated extra argument will be removed.
@pietroalbini pietroalbini self-assigned this Jul 19, 2017
@pietroalbini pietroalbini added this to the botogram 0.4.1 milestone Jul 19, 2017
@pietroalbini pietroalbini removed their assignment Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-regression T-bug
Milestone
botogram 0.4.1
Development

No branches or pull requests
2 participants
@pietroalbini @paolobarbolini