Skip to content

Commit e833729

Browse files
authored
Enable some tests in CI or offline, remove refurb. (#678)
1 parent 413dd2e commit e833729

File tree

6 files changed

+7
-18
lines changed

6 files changed

+7
-18
lines changed

.pre-commit-config.yaml

-4
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ repos:
2929
hooks:
3030
- id: ruff-format
3131
- id: ruff
32-
- repo: https://github.com/dosisod/refurb
33-
rev: v2.0.0
34-
hooks:
35-
- id: refurb
3632
- repo: https://github.com/executablebooks/mdformat
3733
rev: 0.7.22
3834
hooks:

docs/source/changes.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ chronological order. Releases follow [semantic versioning](https://semver.org/)
55
releases are available on [PyPI](https://pypi.org/project/pytask) and
66
[Anaconda.org](https://anaconda.org/conda-forge/pytask).
77

8-
## 0.5.3 - 2025-xx-xx
8+
## 0.5.3 - 2025-05-16
99

1010
- {pull}`650` allows to identify from which data catalog a node is coming from. Thanks
1111
to {user}`felixschmitz` for the report! The feature is enabled by adding an
@@ -15,6 +15,8 @@ releases are available on [PyPI](https://pypi.org/project/pytask) and
1515
- {pull}`671` enhances the documentation on complex repetitions. Closes {issue}`670`.
1616
- {pull}`673` adds de-/serializer function attributes to the `PickleNode`. Closes
1717
{issue}`669`.
18+
- {pull}`677` excludes the latest click v8.2.0 due to compatibility issues.
19+
- {pull}`678` enables some tests in CI or offline, removes refurb.
1820

1921
## 0.5.2 - 2024-12-19
2022

pyproject.toml

-8
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ source = "vcs"
110110
allow-direct-references = true
111111

112112
[tool.ruff]
113-
target-version = "py39"
114113
fix = true
115114
unsafe-fixes = true
116115
extend-include = ["*.ipynb"]
@@ -197,13 +196,6 @@ disable_error_code = ["import-not-found"]
197196
module = ["_pytask.hookspecs"]
198197
disable_error_code = ["empty-body"]
199198

200-
[tool.refurb]
201-
python_version = "3.9"
202-
203-
[[tool.refurb.amend]]
204-
path = "src/_pytask/mark/structures.py"
205-
ignore = ["FURB173"]
206-
207199
[tool.coverage.report]
208200
exclude_also = [
209201
"pragma: no cover",

tests/test_debugging.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def task_example():
173173

174174

175175
@pytest.mark.end_to_end
176-
@pytest.mark.xfail(reason="#312")
176+
@pytest.mark.xfail(os.environ.get("CI") == "true", reason="#312")
177177
@pytest.mark.skipif(not IS_PEXPECT_INSTALLED, reason="pexpect is not installed.")
178178
@pytest.mark.skipif(sys.platform == "win32", reason="pexpect cannot spawn on Windows.")
179179
def test_pdb_interaction_capturing_simple(tmp_path): # pragma: no cover
@@ -285,7 +285,7 @@ def task_2():
285285

286286

287287
@pytest.mark.end_to_end
288-
@pytest.mark.xfail(reason="#312")
288+
@pytest.mark.xfail(os.environ.get("CI") == "true", reason="#312")
289289
@pytest.mark.skipif(not IS_PEXPECT_INSTALLED, reason="pexpect is not installed.")
290290
@pytest.mark.skipif(sys.platform == "win32", reason="pexpect cannot spawn on Windows.")
291291
def test_pdb_interaction_capturing_twice(tmp_path): # pragma: no cover

tests/test_hook_module.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
pytest.param(
1919
True,
2020
marks=pytest.mark.xfail(
21-
sys.platform == "win32" and "CI" in os.environ,
21+
sys.platform == "win32" and os.environ.get("CI") == "true",
2222
reason="pytask is not found in subprocess",
2323
strict=True,
2424
),
@@ -64,7 +64,7 @@ def pytask_extend_command_line_interface(cli):
6464
pytest.param(
6565
True,
6666
marks=pytest.mark.xfail(
67-
sys.platform == "win32" and "CI" in os.environ,
67+
sys.platform == "win32" and os.environ.get("CI") == "true",
6868
reason="pytask is not found in subprocess",
6969
strict=True,
7070
),

tests/test_live.py

-1
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,6 @@ def test_live_execution_displays_subset_of_table(capsys, tmp_path, n_entries_in_
189189

190190

191191
@pytest.mark.unit
192-
@pytest.mark.xfail(reason="See #377.")
193192
def test_live_execution_skips_do_not_crowd_out_displayed_tasks(capsys, tmp_path):
194193
path = tmp_path.joinpath("task_module.py")
195194
task = Task(base_name="task_example", path=path, function=lambda x: x)

0 commit comments

Comments
 (0)