Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypyc benchmark doesn't seem to run mypyc #5

Closed
mdboom opened this issue Jun 29, 2022 · 1 comment
Closed

mypyc benchmark doesn't seem to run mypyc #5

mdboom opened this issue Jun 29, 2022 · 1 comment

Comments

@mdboom
Copy link
Collaborator

mdboom commented Jun 29, 2022

I'm working on updating the mypy benchmark to be compatible with Python 3.11 (primarily by just updating the dependencies). However, I've run into a small snag. The mypyc benchmark, which is a "subbenchmark" of mypy, doesn't actually seem to run mypyc -- it just runs the same thing as the mypy benchmark with 50 loops rather than 20. Additionally, there is a bug when running in the pyperformance harness since the results of both of these use the same name (mypy).

I think we should either:

  1. Add a new benchmark that legitimately runs mypyc
  2. Just remove the mypyc benchmark

Thoughts?

@kmod kmod closed this as completed in 8121f37 Jul 7, 2022
@kmod
Copy link
Contributor

kmod commented Jul 7, 2022

Ah thanks for pointing this out, looks like this needs a little bit more work so I just removed the mypyc benchmark for now.

Just a word of caution that the mypy wheels on pypi are built using mypyc whereas their sdist is configured to not use mypyc, so this means that if you're comparing a Python version that has a mypy wheel vs one that doesn't you will see a large performance difference due to this. I think this should be addressed by python/pyperformance#195 in newer versions of pyperformance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants