Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrument_altitude_to_model_pressure as pysat.custom compatible function #54

Open
aburrell opened this issue Jul 20, 2020 · 6 comments
Assignees
Milestone

Comments

@aburrell
Copy link
Member

Is your feature request related to a problem? Please describe.
instrument_altitude_to_model_pressure routine does not works as a pysat.custom function for TIEGCM.

Describe the solution you'd like
Change instrument_altitude_to_model_pressure routine works as a pysat.custom function

@aburrell
Copy link
Member Author

Extracting this from PR #36

@aburrell aburrell added this to the 1.0.0 release milestone Apr 21, 2021
@rstoneback
Copy link
Collaborator

Should I convert all the functions in extract or only instrument_altitude_to_model_pressure?

@aburrell
Copy link
Member Author

aburrell commented Nov 4, 2021

Any of the ones that are appropriate. I think the main extract routine isn't an appropriate candidate.

@rstoneback
Copy link
Collaborator

ok, I can leave out the extract_modeled_observations one and convert the rest. I'm going to remove the returned keys and convert the xarray dataset input to expect a pysat.Instrument input for the model.

@aburrell
Copy link
Member Author

aburrell commented Nov 4, 2021

Hmmm... maybe we should wait then. I am not sure what else will break if we change the inputs.

@aburrell
Copy link
Member Author

How about creating some wrapper functions that use the utilities as pysat functions?

@aburrell aburrell modified the milestones: 1.0.0 release, 0.2.0 May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants