Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: ICON TIEGCM file download and pysatNASA 0.0.5 #128

Open
jklenzing opened this issue Jun 15, 2023 · 1 comment · May be fixed by #132
Open

BUG: ICON TIEGCM file download and pysatNASA 0.0.5 #128

jklenzing opened this issue Jun 15, 2023 · 1 comment · May be fixed by #132
Assignees
Labels
bug Something isn't working

Comments

@jklenzing
Copy link
Member

Describe the bug
pysatNASA 0.0.5 cdaweb download updates data_path from kwarg to arg. This is a breaking change for the implementation here.

To Reproduce

import pysat
tiegcm = pysat.Instrument('ucar', 'tiegcm', tag='icon')
tiegcm.download_updated_files()

Expected behavior
files should download

Screenshots

FAILED pysatModels/tests/test_models.py::TestModels::test_download[inst_dict2] - TypeError: download() got multiple values for argument 'data_path'

Desktop (please complete the following information):

  • OS: Monterrey
  • Version python 3.10.9

Additional context
testing against pysatNASA RC

@jklenzing jklenzing added the bug Something isn't working label Jun 15, 2023
@jklenzing
Copy link
Member Author

Long term fix: moving the unzip routine to pysatNASA (see pysat/pysatNASA#103) should streamline this.

@jklenzing jklenzing mentioned this issue Jul 6, 2023
10 tasks
@jklenzing jklenzing linked a pull request Oct 5, 2023 that will close this issue
10 tasks
@jklenzing jklenzing self-assigned this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant