transfer of closed pr from pysal-meta

[sjsrey]

pysal/pysal#1055

[ljwolf]

We would need to sift through these more to figure out what is still needed, but my recollection is that @pedrovma and I worked pretty closely together to get all this stuff in already to the current spreg release. It appears only 2 things are missing, and only 1 of these is substantive (the spdot in the concentrated log likelihoods):

• the init has the sur imports (upstream, here)
• The chisqprob deprecation fix was removed (upstream, here) somehow when it came here. I've read that chisqprob was removed, but I am still able to run from scipy.stats import chisqprob on version 1.2.1 of scipy, so I'm not sure what's up. A deprecation fix for this was retained in diagnostics_sp.py, (upstream, here)
• Changes to diagnostics_sur.py appear to be applied correctly. (upstream, here)
• The removal of the extra regime_err_sep is done (upstream, here).
• Changes to the concentrated log likelihood remain undone (upstream, here).
• Regimes patch was applied. (upstream, here)
• Spatial diagnostics for ML models is enforced. (upstream, here), as well as later changes to the SUR summary (upstream, here)
• Changes to sur_lag.py look applied. (upstream, here), as well as to sur.py (upstream, here), sur_error.py (upstream, here) and sur_utils.py (upstream, here)

The remaining changes appear to not be things we need (e.g. referring to pysal.spreg as econometrics), and changes to testing that have been merged, or changes to documentation that we decided together not to merge.