handling edge cases in preprocessing.FaceArtifacts
#666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jGaboardi
changed the title
preprocessing. FaceArtifactspreprocessing.FaceArtifacts
martinfleis
reviewed
Nov 11, 2024
| "Identification of face artifacts not possible.", | ||
| UserWarning, | ||
| stacklevel=2, | ||
| ) |
There was a problem hiding this comment.
Suggested change
| ) | |
| ) | |
| self.threshold = None | |
| self.face_artifacts = None |
I am not sure if we should not do this and maybe some other.
There was a problem hiding this comment.
So should we go ahead and assign all possible attributes as None?
kdepdfpeaksd_peaksvalleysd_valleysthresholdface_artifacts
There was a problem hiding this comment.
I went ahead and pushed up all attr = None
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
=======================================
+ Coverage 97.4% 98.1% +0.8%
=======================================
Files 26 40 +14
Lines 4328 7180 +2852
=======================================
+ Hits 4214 7046 +2832
- Misses 114 134 +20
|
martinfleis
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
preprocessing.FaceArtifacts#664"face_artifact_index"leads toLinAlgErrorinpreprocessing.FaceArtifacts#665