Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.5.0 release #160

Closed
jGaboardi opened this issue Jan 12, 2023 · 11 comments
Closed

v2.5.0 release #160

jGaboardi opened this issue Jan 12, 2023 · 11 comments
Assignees
@sjsrey @knaaptime @weikang9009 @jGaboardi @martinfleis
Labels
release

Comments

@jGaboardi
Copy link
Member

I'd like to cut a fresh release (v2.5.0?) for this month's PySAL meta release. Anything else to add/adjust/etc. before that?
@martinfleis
Copy link
Member

Fine with me as is.

This was referenced Jan 13, 2023
Closed
Closed
Merged
@jGaboardi
Copy link
Member Author

jGaboardi commented Jan 13, 2023 •
edited
Loading

v2.5.0rc1 docs are live. And version is out on pip.

@sjsrey
Copy link
Member

sjsrey commented Jan 13, 2023

Some of the links a broken with the change from master to main as the default branch. Click the images at:

https://pysal.org/mapclassify/index.html

@jGaboardi
Copy link
Member Author

Some of the links a broken with the change from master to main as the default branch. Click the images at:

https://pysal.org/mapclassify/index.html

Good catch!

@jGaboardi
Copy link
Member Author

@sjsrey I just noticed that all three links go to the same notebook; there are simply 3 different PNGs. This was going back to at least the last release. I am assuming it's desired behavior?

@jGaboardi jGaboardi mentioned this issue Jan 13, 2023
Merged
@sjsrey
Copy link
Member

sjsrey commented Jan 13, 2023

yes - the notebook demonstrates the ability to change the options to generate different classifications.

@jGaboardi
Copy link
Member Author

v2.5.0rc2 docs are live. And version is out on pip.

@jGaboardi
Copy link
Member Author

I'll cut the v2.5.0 once we're satisfied.

@jGaboardi jGaboardi mentioned this issue Jan 14, 2023
Merged
@jGaboardi
Copy link
Member Author

confirmed #167 works as no PR was opened with v2.5.0rc3.

@jGaboardi
Copy link
Member Author

v2.5.0 is cut.

@jGaboardi
Copy link
Member Author

Might want to consider a v2.5.1 patch release after #168 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjsrey sjsrey

@knaaptime knaaptime

@weikang9009 weikang9009

@jGaboardi jGaboardi

@martinfleis martinfleis

Labels
release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sjsrey @knaaptime @weikang9009 @jGaboardi @martinfleis