Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FutureWarning: Objects based on the Geometry class will deprecated and removed in a future version of libpysal #769

Open
catamech-aubay opened this issue Nov 4, 2024 · 5 comments

Comments

@catamech-aubay
Copy link

I was searching for an alternative for the 'Geometry' class that will be deprecated and removed in a future version (undefined), I need to find a solution to be able to use 'Point' and 'Polygon' shapes precisely, but I couldn't find any documentation or previous issue concerning this subject, any idea when will it be deprecated and if there is any suggested solution ?

@ljwolf
Copy link
Member

ljwolf commented Nov 4, 2024

I would recommend considering pygeoif for this functionality. PySAL's geometry types are not OGC-compliant, and were designed to match now outdated reference implementations of ESRI geometries.

@martinfleis
Copy link
Member

@ljwolf Why not shapely? That's likely the most robust no?

@ljwolf
Copy link
Member

ljwolf commented Nov 4, 2024

pygeoif is pure python, lightweight, and generally easier for people to install. Shapely is an excellent option, too, but if a user is searching for a pysal.geometry replacement, I think pygeoif is the closest substitution.

@martinfleis
Copy link
Member

I tend to disagree a bit in here. Installing shapely has not been an issue lately and while it is not pure python it is way more feature complete. And importantly, it is what most of the ecosystem uses. Let's pick it up on Thursday during the dev call to formulate some recommendations on where to point people. I have always assumed we do deprecate and suggest replacement by shapely as that is what we do internally but that might have been a wrong assumption.

@ljwolf
Copy link
Member

ljwolf commented Nov 4, 2024

All of that is true. But, pysal geometry classes were written to avoid depending on geos. Hence I'd think a successor recommendation should include a non-geos option.I think if people can get it, shapely is the thing to use!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants