GitAction should not be launched if a PR is closed but not merged (#192)

* fix(gitAction): should not be launched if a PR is closed but not merged * improve logging
pyronear · May 20, 2024 · 94469dd · 94469dd
1 parent 25bd5ad
commit 94469dd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/.github/workflows/build-push-image.yml b/.github/workflows/build-push-image.yml
@@ -1,10 +1,6 @@
 name: Build and Push Docker Image
 
 on:
-  pull_request:
-    types: [closed]
-    branches:
-      - develop
   push:
     branches:
       - develop

diff --git a/pyroengine/engine.py b/pyroengine/engine.py
@@ -381,7 +381,6 @@ def _process_alerts(self) -> None:
                 # Media creation
                 if not isinstance(self._alerts[0]["media_id"], int):
                     self._alerts[0]["media_id"] = self.api_client[cam_id].create_media_from_device().json()["id"]
-
                 # Alert creation
                 if not isinstance(self._alerts[0]["alert_id"], int):
                     self._alerts[0]["alert_id"] = (
@@ -394,7 +393,6 @@ def _process_alerts(self) -> None:
                         )
                         .json()["id"]
                     )
-
                 # Media upload
                 stream = io.BytesIO()
                 frame_info["frame"].save(stream, format="JPEG", quality=self.jpeg_quality)
@@ -408,8 +406,9 @@ def _process_alerts(self) -> None:
                 self._alerts.popleft()
                 logging.info(f"Camera '{cam_id}' - alert sent")
                 stream.seek(0)  # "Rewind" the stream to the beginning so we can read its content
-            except (KeyError, ConnectionError):
+            except (KeyError, ConnectionError) as e:
                 logging.warning(f"Camera '{cam_id}' - unable to upload cache")
+                logging.warning(e)
                 break
 
     def _local_backup(self, img: Image.Image, cam_id: str, is_alert: bool = False) -> None: