Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Prohibit passing negative numbers to plate sizes #3407

Open
deoxyribose opened this issue Oct 24, 2024 · 0 comments
Open

Feature request: Prohibit passing negative numbers to plate sizes #3407

deoxyribose opened this issue Oct 24, 2024 · 0 comments
Labels
help wanted Issues suitable for, and inviting external contributions usability

Comments

@deoxyribose
Copy link
Contributor

Issue Description

Plate primitives scale log-likelihood terms by size/batch_size. But plates allow negative numbers without a warning or assert.
Something like
assert size > 0
above https://github.com/pyro-ppl/pyro/blob/dev/pyro/primitives.py#L424
might be worth adding.
@fritzo fritzo added help wanted Issues suitable for, and inviting external contributions usability labels Oct 24, 2024
@deoxyribose deoxyribose mentioned this issue Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues suitable for, and inviting external contributions usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deoxyribose @fritzo