Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Duplicate engines in Active Engine dropdown in Settings + Update Revit versions #2389

Open
5 tasks done
sanzoghenzo opened this issue Sep 5, 2024 · 2 comments
Open
5 tasks done

[Bug]: Duplicate engines in Active Engine dropdown in Settings + Update Revit versions #2389

sanzoghenzo opened this issue Sep 5, 2024 · 2 comments
Assignees
@sanzoghenzo
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] pyRevit 5 pyRevit 5 coming release
Milestone
pyRevit 5 RC

Comments

@sanzoghenzo
Copy link
Contributor

✈ Pre-Flight checks

  • I don't have SentinelOne antivirus installed (see above for the solution)
  • I have searched in the issues (open and closed) but couldn't find a similar issue
  • I have searched in the pyRevit Forum for similar issues
  • I already followed the installation troubleshooting guide thoroughly
  • I am using the latest pyRevit Version

🐞 Describe the bug

A picure is worth more than a thousand words:

image

This is because we duplicate the engines for .net core and .net framework, but in the interface we should list them only once.

⌨ Error/Debug Message

see picture

♻️ To Reproduce

  1. Open pyrevit 5 settings
  2. Click on the "Active engine" dropdown

⏲️ Expected behavior

Engines are listed only once

🖥️ Hardware and Software Setup (please complete the following information)

pyRevit 5 WIP, the rest doesn't matter.

Additional context

No response
@sanzoghenzo sanzoghenzo added Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] pyRevit 5 pyRevit 5 coming release labels Sep 5, 2024
@sanzoghenzo sanzoghenzo added this to the pyRevit 5 RC milestone Sep 5, 2024
@sanzoghenzo
Copy link
Contributor Author

Also, the settings UI is missing the last revit version

image

@sanzoghenzo sanzoghenzo changed the title [Bug]: Duplicate engines in Active Engine dropdown in Settings [Bug]: Duplicate engines in Active Engine dropdown in Settings + Update Revit versions Sep 5, 2024
@jmcouffin jmcouffin mentioned this issue Sep 6, 2024
Open
@jmcouffin
Copy link
Contributor

jmcouffin commented Sep 6, 2024 •
edited
Loading

Also, the settings UI is missing the last revit version

manual fix in @2384 PR
The automation of this part should be addressed later as it is not urgent

sanzoghenzo pushed a commit to sanzoghenzo/pyRevit that referenced this issue Sep 13, 2024
fix: engines correclty detected
e3e661a 
this partially rolls back 239d918 because it introduced a blocking bug.

fixes pyrevitlabs#2389 pyrevitlabs#2385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanzoghenzo sanzoghenzo

Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] pyRevit 5 pyRevit 5 coming release
Projects
pyRevit
Status: In Progress
Milestone
pyRevit 5 RC
Development

No branches or pull requests
2 participants
@sanzoghenzo @jmcouffin