Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate_fuels contains two definitions of the coal_fuels list and extra values not present in get_conv_factors #310

Open
2 tasks
finozzifa opened this issue May 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@finozzifa
Copy link
Contributor

finozzifa commented May 15, 2024

Checklist

  • I am using the current main branch or the latest release. Please indicate.
  • I am running on an up-to-date pypsa-africa environment. Update via conda env update -f envs/environment.yaml.

Describe the Bug

In a nutshell, one of the inputs used in pypsa-earth-sec for rule build_base_energy_totals contains a few typos (e.g. "Hrad coal") and many duplicated entries (e.g. "Coke-oven coke", "Coke oven coke" and "Coke Oven Coke"). Such typos and duplicated entries have been propagated in the method get_conv_factors and in the method aggregate_fuels. Moreover, aggregate_fuels contains two mutually exclusive definitions for the list coal_fuels. Finally, the method aggregate_fuels does not use the function argument sector. More details below:

-) Issue 1 : aggregate_fuels contains two definitions of the coal_fuels list. Namely

coal_fuels = [
    "Anthracite",
    "Brown coal",
    "Brown coal briquettes",
    "Coke-oven coke",
    "Coke Oven Coke",
    "Hard coal",
    "Other bituminous coal",
    "Sub-bituminous coal",
    "Coking coal",
    "Bitumen",
]

and

coal_fuels = [
    "Anthracite",
    "Charcoal",
    "Coke oven coke",
    "Coke-oven coke",
    "Coke Oven Coke",
    "Coking coal",
    "Hard coal",
    "Other bituminous coal",
    "Petroleum coke",
    "Petroleum Coke",
    "Hrad coal",
    "Lignite",
    "Peat",
    "Peat products",
]

-) Issue 2 : the argument sector in aggregate_fuels is not used in the function.

-) Issue 3 : the method aggregate_fuels is used in conjunction with the method get_conv_factors. However not all entries from aggregate_fuels are present in get_conv_factors. For example "Blast Furnace Gas" is present is aggregate_fuels but not in get_conv_factors

-) Issue 4: the input data processed with the methods contain typos. For example Hrad coal, instead of Hard coal.

@finozzifa finozzifa added the bug Something isn't working label May 15, 2024
@finozzifa finozzifa changed the title aggregate_fuels contains two definitions of the coal_fuels list aggregate_fuels contains two definitions of the coal_fuels list and extra values not present in get_conv_factors May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant