You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am using the current main branch or the latest release. Please indicate.
I am running on an up-to-date pypsa-africa environment. Update via conda env update -f envs/environment.yaml.
Describe the Bug
In a nutshell, one of the inputs used in pypsa-earth-sec for rule build_base_energy_totals contains a few typos (e.g. "Hrad coal") and many duplicated entries (e.g. "Coke-oven coke", "Coke oven coke" and "Coke Oven Coke"). Such typos and duplicated entries have been propagated in the method get_conv_factors and in the method aggregate_fuels. Moreover, aggregate_fuels contains two mutually exclusive definitions for the list coal_fuels. Finally, the method aggregate_fuels does not use the function argument sector. More details below:
-) Issue 1 : aggregate_fuels contains two definitions of the coal_fuels list. Namely
-) Issue 2 : the argument sector in aggregate_fuels is not used in the function.
-) Issue 3 : the method aggregate_fuels is used in conjunction with the method get_conv_factors. However not all entries from aggregate_fuels are present in get_conv_factors. For example "Blast Furnace Gas" is present is aggregate_fuels but not in get_conv_factors
-) Issue 4: the input data processed with the methods contain typos. For example Hrad coal, instead of Hard coal.
The text was updated successfully, but these errors were encountered:
finozzifa
changed the title
aggregate_fuels contains two definitions of the coal_fuels list
aggregate_fuels contains two definitions of the coal_fuels list and extra values not present in get_conv_factors
May 21, 2024
Checklist
main
branch or the latest release. Please indicate.pypsa-africa
environment. Update viaconda env update -f envs/environment.yaml
.Describe the Bug
In a nutshell, one of the inputs used in pypsa-earth-sec for rule build_base_energy_totals contains a few typos (e.g. "Hrad coal") and many duplicated entries (e.g. "Coke-oven coke", "Coke oven coke" and "Coke Oven Coke"). Such typos and duplicated entries have been propagated in the method get_conv_factors and in the method aggregate_fuels. Moreover, aggregate_fuels contains two mutually exclusive definitions for the list coal_fuels. Finally, the method aggregate_fuels does not use the function argument sector. More details below:
-) Issue 1 : aggregate_fuels contains two definitions of the coal_fuels list. Namely
and
-) Issue 2 : the argument sector in aggregate_fuels is not used in the function.
-) Issue 3 : the method aggregate_fuels is used in conjunction with the method get_conv_factors. However not all entries from aggregate_fuels are present in get_conv_factors. For example "Blast Furnace Gas" is present is aggregate_fuels but not in get_conv_factors
-) Issue 4: the input data processed with the methods contain typos. For example Hrad coal, instead of Hard coal.
The text was updated successfully, but these errors were encountered: